Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] l10n_ch_base_bank #686

Closed
wants to merge 152 commits into from
Closed

[16.0] [MIG] l10n_ch_base_bank #686

wants to merge 152 commits into from

Conversation

ivantodorovich
Copy link

It follows up after:

It includes:

And a number of other improvements, each in a different commit to ease review

nbessi and others added 30 commits January 3, 2023 12:58
@nbessi @ivantodorovich
[IMP] refactoring module structure
987ad6a
@nbessi @ivantodorovich
[FIX] port of base bank
5e25c9e
@nbessi @ivantodorovich
[REF] bvr report
3de5400
@nbessi @ivantodorovich
[REF] bvr duplicated stuff
3602bf4
@nbessi @ivantodorovich
[REF] move from spli to bank"
edd3064
@nbessi @ivantodorovich
[FIX] non serializable type
12de324
@nbessi @ivantodorovich
[FIX] default in sale workflow fo generated invoices
b25a457
@nbessi @ivantodorovich
[TYPO]
dd490ce
@nbessi @ivantodorovich
[REFACTOR] bank dispertion
1a185cb
@nbessi @ivantodorovich
[FIX] contributors list
3b222f6
@nbessi @ivantodorovich
[FIX] encoding metadata
ae56c1d
@nbessi @ivantodorovich
[ADD] add post related field
278ce40
@nbessi @ivantodorovich
[IMP] add notion of CCP on bank instead of having an account on res.p…
c087746 
…artner.bank.

The code is retro compatible and if you do not have a ccp on bank it will act as before
@nbessi @ivantodorovich
[IMP] change version of addons + update changelog
e94a791
@nbessi @ivantodorovich
[FIX] res.partner.bank view
74d1fb4
@nbessi @ivantodorovich
[FIX] ccp related is read only
a061007
@nbessi @ivantodorovich
[FIX] blank line
cc8ccb7
@nbessi @ivantodorovich
[FIX] bank view city and zip where duplicated
08a87da
@nbessi @ivantodorovich
[FIX] hide ccp if the bic is the postfinance one
0add932
@nbessi @ivantodorovich
[FIX] bank search and name get. Add a intelligent name search and add…
8b81079 
… city to name get
@nbessi @ivantodorovich
[ADD] street on res.bank name_get and name_search
e8091b9
@vrenaville @ivantodorovich
[FIX]only bvr requiered bvr ref
42c9a55
@jgrandguillaume @ivantodorovich
[IMP] Add all translations .pot file in order to allow people to tran…
d1dd1bc 
…slate module on LP
@guewen @ivantodorovich
fix a bug when an account number is empty
f6295cb
@ivantodorovich
Launchpad automatic translations update.
877d91f
@nbessi @ivantodorovich
Set all addons to uninstallable
3eac10a
@nbessi @ivantodorovich
Rename all addons to xxx_unported
f158782
@PCatinean @ivantodorovich
[ADD] Added l10n_ch_base_bank migrated to the new api
15ba7ba
@nbessi @ivantodorovich
Cleanup of l10n_ch_base_bank port
8bc7b20
@nbessi @ivantodorovich
Remove deprecated size
9cbf5a4
yvaucher and others added 23 commits January 4, 2023 09:40
@yvaucher @ivantodorovich
Fix removed view
c57b0d3
@yvaucher @ivantodorovich
Fix test set empty M2O with empty recordset
5bbc01a
@yvaucher @ivantodorovich
Clearing do not have leading 0s
c0224ea
@yvaucher @ivantodorovich
[REF] l10n_ch_postal onchanges
8db9463 
Replace "Postal number" by "ISR"
Detect an ISR subscription number based on the leading digits 01 or 03
@yvaucher @ivantodorovich
Document
0b9d634
@yvaucher @ivantodorovich
Signature change of _is_isr_ref
51f0371
@yvaucher @ivantodorovich
Adapt to odoo core change that removed _is_isr_ref
164796a 
Follow the removal from here: odoo/odoo#53815
@yvaucher @ivantodorovich
[TR] remove useless terms of invoice.py
edffd37
@SimoneVagile @ivantodorovich
[14.0][MIG] l10n_ch_base_bank
85cdf6d
@TDu @ivantodorovich
[14.0][FIX] l10n_ch_base_bank
37121a7 
This is a forward port of

* OCA#603

On an unrelated PR the test for l10n_ch_base_bank were broken.
It seems to be related to this new change introduced by

* odoo/odoo#67599

Which test the valid of the type journal.

So this fixes the test, but I am not sure if they are still meaningfull.
@ivantodorovich
[MIG] l10n_ch_account_tags: Migration to 14.0
6c457f7
@hailangvn @ivantodorovich
[FIX] l10n_ch_base_bank: fix tests
a449228
@ivantodorovich
[IMP] l10n_ch_base_bank: pre-commit execution
e6e05b0
@ivantodorovich
[15.0][MIG] l10n_ch_base_bank: Migrate to version 15.0
248ae66
@ivantodorovich
[MIG] l10n_ch_base_bank: Migration to 16.0
6946350 
* Rename model files to match their model names
* Remove 'end year' of copyright comments (it's useless)
@ivantodorovich
[IMP] l10n_ch_base_bank: Move _search on normalized ref to a separate…
d689b82 
… field
@santostelmo @ivantodorovich
[IMP] l10n_ch_base_bank: remove isr check
2d2a66e
@ivantodorovich
[IMP] l10n_ch_base_bank: split code that depends on account_payment_p…
c372be0 
…artner
@ivantodorovich
[IMP] l10n_ch_base_bank: don't fully overwrite name_search
19cbd30
@ivantodorovich
[IMP] l10n_ch_base_bank: don't fully overwrite name_get
0c71d8d
@ivantodorovich
[IMP] l10n_ch_base_bank: remove unused method
57b2f8c
@ivantodorovich
[IMP] l10n_ch_base_bank: Remove field that's already defined in core
7b6037d
@ivantodorovich
[IMP] l10n_ch_base_bank: Remove unused method 'is_isr_issuer'
30d548c 
Moreover, there's a similar method that already exists in core, so it's
pointless to have this one.
This was referenced Jan 4, 2023
Closed
Open
yvaucher
yvaucher reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ISR part is now obsolete since end of last year.

We should drop this module as it only exists for that.

@ivantodorovich
Copy link
Author

Alright, closing this PR then

@leemannd leemannd mentioned this pull request May 21, 2024
Closed
@BT-anieto BT-anieto mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvaucher yvaucher yvaucher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.