Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [ADD] endesive to report_qweb_signer #528

Merged

Conversation

Laurent-Corron
Copy link

@Laurent-Corron Laurent-Corron commented Jul 19, 2021

This adds endesive as an option to digitally sign documents in report_qweb_signer

@Laurent-Corron Laurent-Corron force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch 3 times, most recently from 9546451 to b04dd19 Compare July 19, 2021 08:52
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestion on field labels, otherwise looks very good.

report_qweb_signer/models/report_certificate.py Outdated Show resolved Hide resolved
report_qweb_signer/models/report_certificate.py Outdated Show resolved Hide resolved
report_qweb_signer/models/report_certificate.py Outdated Show resolved Hide resolved
report_qweb_signer/models/report_certificate.py Outdated Show resolved Hide resolved
report_qweb_signer/models/report_certificate.py Outdated Show resolved Hide resolved
report_qweb_signer/models/report_certificate.py Outdated Show resolved Hide resolved
@Laurent-Corron Laurent-Corron force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch from b04dd19 to 1446c46 Compare July 19, 2021 13:31
@Laurent-Corron
Copy link
Author

@sbidoul
All feedbacks have been done!

@pedrobaeza pedrobaeza added this to the 13.0 milestone Jul 19, 2021
@sbidoul
Copy link
Member

sbidoul commented Jul 21, 2021

@Laurent-Corron can you rebase now that #522 is merged ? Can you also check why travis is red, and remove /usr/bin/java from the manifest ?

@Laurent-Corron Laurent-Corron force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch from 1446c46 to 1d42eb3 Compare July 23, 2021 12:27
requirements.txt Outdated Show resolved Hide resolved
@Laurent-Corron Laurent-Corron force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch from 1d42eb3 to a9a9a4a Compare July 26, 2021 07:58
@sbidoul sbidoul mentioned this pull request Jul 27, 2021
@sbidoul sbidoul force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch from a9a9a4a to cd738dc Compare July 27, 2021 14:05
@sbidoul
Copy link
Member

sbidoul commented Jul 27, 2021

Rebased to get swig.

@Laurent-Corron Laurent-Corron force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch 3 times, most recently from 0d3727a to 4a71750 Compare July 29, 2021 14:03
@Laurent-Corron Laurent-Corron force-pushed the 13.0-add-endesive-report_qweb_signer-lco branch from 4a71750 to a770c10 Compare July 29, 2021 14:41
@sbidoul
Copy link
Member

sbidoul commented Aug 2, 2021

@pedrobaeza if ok for you this is ready to merge.

@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-528-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d51766e into OCA:13.0 Aug 4, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3601d6d. Thanks a lot for contributing to OCA. ❤️

yajo pushed a commit to Tecnativa/calendar that referenced this pull request Aug 5, 2021
This dependency was introduced in the recently merged OCA/reporting-engine#528.
@ThomasBinsfeld ThomasBinsfeld deleted the 13.0-add-endesive-report_qweb_signer-lco branch August 18, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants