[14.0][MIG] report_qweb_signer #534
Conversation
OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot
- Good dependency chain - Context for forcing rendering PDF - Extra test [UPD] README.rst [UPD] Update report_qweb_signer.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/ [UPD] README.rst
`render_qweb_pdf` must return a tuple of `(content, 'pdf')`
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/
Fix website on manifest
[UPD] Update report_qweb_signer.pot [UPD] README.rst
Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_qweb_signer/
|
Hi @omar7r! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the |
…isible signatures
omar7r
force-pushed
the
14.0-mig-report_qweb_signer
branch
from
206f3b4
to
54bf4b0
Compare
|
There has been also some moves in v13 version to add (and planning to switch to) a new Python library. |
At the time I didn't find a library mature enough to stick to, although the current implementation isn't very neat anyway... |
|
@pedrobaeza @chienandalu We have positive results so far with endesive but no large scale production feedback yet. So its probably premature to drop the java code yet. |
|
Oh, yeah. That the one I had spotted but two years ago it was fairly new |
|
Ok, then at least this PR should be updated with latest 13.0 commits |
|
And there is also #533 that is pending. |
We don't want our custom parameters be reset every time the module updates. TT32256
…default and fix multicompany issue
…objects (print from wizard in some cases)
|
@omar7r did you check about the new sign method? Travis is red by the way. |
|
Yes, I tested two options, both works fine. I think that Travis fails because needs to have installed the package swig in the system, where can I add it? |
|
You can put it on |
|
Should we remove Java library then and leave only the Pythonic one? |
|
Out of curiosity, how do both methods compare in performance when printing a big number of signed documents? |
|
Swig it's a dependency in the machine not at python level. In our case, we are using java's library in production, because the project was a migration, from 10.0 to 14.0, I don't test the python library printing several invoices at time. I don't know if someone use the pythonic lib in production and could give feedback, if not, it will be a good test to do, before the decision. |
|
Then you need to change .travis.yml to install such dependency: https://github.com/OCA/reporting-engine/blob/13.0/.travis.yml#L15 |
|
Hello @omar7r , are you working on this PR? If not, I can supersede it to speed up the migration, thanks. |
|
Yes, but I didn't have much time since your comment, on friday I think I can review it. |
omar7r
force-pushed
the
14.0-mig-report_qweb_signer
branch
from
1991b11
to
849d8f1
Compare
|
@ernestotejeda I tested it again locally and it works, maybe Runbot doesn't have enough memory for running Java. |
|
/ocabot migration report_qweb_signer |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 945e958. Thanks a lot for contributing to OCA. ❤️ |
No description provided.