Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [16.0] base_rest #312

Closed
wants to merge 2 commits into from
Closed

Conversation

Nikul-OSI
Copy link
Contributor

No description provided.

@dreispt
Copy link
Member

dreispt commented Nov 30, 2022

Thank you Nikul.
Is this ready for review?
Why are tests failing?

@dreispt
Copy link
Member

dreispt commented Nov 30, 2022

PS: and please squash your commits. Thank you.

@Nikul-OSI Nikul-OSI force-pushed the 16-nc-mig-base_rest branch 2 times, most recently from 5bbf24e to 5e598dd Compare December 1, 2022 06:58
@StefanRijnhart

This comment was marked as outdated.

@StefanRijnhart
Copy link
Member

Hi Nikul, our paths cross again. I found your work on Friday and I tried to improve on it but I did not manage to fully deliver it. I've left it here as work in progress just for reference: #313

I'm finding this very difficult, I must say! Maybe we can keep in touch about the remaining issues?

@StefanRijnhart
Copy link
Member

Let's continue on #313

@Nikul-OSI Nikul-OSI deleted the 16-nc-mig-base_rest branch December 21, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants