[MIG] base_rest, base_rest_auth_api_key, base_rest_datamodel, base_rest_demo, base_rest_pydantic, datamodel, extendable: Migration to 16.0

[StefanRijnhart]

Started out from #312. I assigned co-authorship of the main migration commit to @Nikul-OSI.

• Added warning to base_rest about the module being deprecated and removed @lmignon as maintainer (as per [MIG] base_rest, base_rest_auth_api_key, base_rest_datamodel, base_rest_demo, base_rest_pydantic, datamodel, extendable: Migration to 16.0 #313 (comment))
• Removed adding non existing modules to the Odoo registry as it is harmful in Odoo 16. It makes Odoo halt while fetching web assets and while fetching tests to run. Removing this code does not seem to break anything.
• Introduced a new restapi route type to trigger the dispatcher provided by base_rest as the new dispatcher registry is segmented by route type.
• In Odoo 16 the routing is encoded in an original_routing attribute of the controller methods rather than a routing attribute. I've applied the ROUTING_DECORATOR_ATTR constant throughout the code.

[lmignon]

@StefanRijnhart I don't plan to continue to work with base_rest for my own projects (at least at this stage). I'll finalize the integration with fastapi since this new addon add a lot benefits over base_rest.

[StefanRijnhart]

@lmignon thanks for commenting. I'm adding a warning about that during the loading of base_rest. I thought I'd remove you as the maintainer of the module as well but let me know if you like to keep it.
We'll probably migrate to your fastapi integration when it's ready but we need something to get started on for Odoo 16.

[lmignon]

You can remove me as maintainer even if I could still contribute if we need it for legacy code. Into the migration you could also remove all the process that transform the code from the old api to the new one. (A warning has been added in 14.0 #270 to notify that the implicit mode is deprecated)

[StefanRijnhart]

@lmignon at this point removing obsolete code from a deprecated module does not seem worth the trouble ;-)

[StefanRijnhart]

@lmignon thanks, I added another test now with a different parameter than id.

[lmignon]

Thank you @StefanRijnhart LGTM (Code review)

[StefanRijnhart]

Thanks for the review! I squashed the fixup commits.

[lmignon]

@marielejeune @qgroulard Can you make a test with this RP. I have in mind that you have modules to migrate in 16 that are based on base_rest. It would be great to have an additional functional review/test.

[FrancoMaxime]

LGTM & Functional review

[FrancoMaxime]

@lmignon, as you requested you have been removed from the list of maintainers for this module. Maybe you would like to be removed from other modules like base_rest_demo?

[StefanRijnhart]

@HoangSang1510, kindly reminding you to test the latest version of this code.

[marielejeune]

Thanks for the work! LGTM (functional tests)

[lmignon]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-313-by-lmignon-bump-nobump, awaiting test results.

[lmignon]

Thank you to all reviewers and contributors (especially @StefanRijnhart) ! It's time to merge this huge work.

[OCA-git-bot]

Congratulations, your PR was merged at 49db9e6. Thanks a lot for contributing to OCA. ❤️

[StefanRijnhart]

Thanks for all the reviews and to @Nikul-OSI for his part in the migration!

[HoangSang1510]

@HoangSang1510, kindly reminding you to test the latest version of this code.

I have updated to latest version, now it work perfectly in my project. Thank you very much!

[StefanRijnhart]

@HoangSang1510 thanks for confirming!