Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] backport auth_jwt and auth_jwt_demo improvements from 16.0 #531

Merged
merged 9 commits into from
Jul 17, 2023
Merged

[14.0][MIG] backport auth_jwt and auth_jwt_demo improvements from 16.0 #531

merged 9 commits into from
Jul 17, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jun 23, 2023 •
edited
Loading

@sbidoul sbidoul added this to the 14.0 milestone Jun 23, 2023
@sbidoul sbidoul mentioned this pull request Jun 23, 2023
Closed
@sbidoul sbidoul mentioned this pull request Jun 28, 2023
Closed
2 tasks
lmignon
lmignon approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@sbidoul sbidoul mentioned this pull request Jul 1, 2023
Open
4 tasks
OCA-git-bot pushed a commit that referenced this pull request Jul 2, 2023
@lasley @astirpe
[9.0][ADD] Password Security Settings (#531)
4c7507c 
* [ADD] res_users_password_security: New module
* Create new module to lock down user passwords

* [REF] res_users_password_security: PR Review fixes
* Also add beta pass history rule

* [ADD] res_users_password_security: Pass history and min time
* Add pass history memory and threshold
* Add minimum time for pass resets through web reset

* Begin controller tests

* Fix copyright, wrong year for new file

* Add tests for password_security_home
* Left to do web_auth_reset_password

* Fix minimum reset threshold and finish tests

* Bug fixes per review

* [REF] password_security: PR review improvements
* Change tech name to password_security
* Use new except format
* Limit 1 & new api
* Cascade deletion for pass history

* [REF] password_security: Fix travis + style
* Fix travis errors
* self to cls
* Better variable names in tests

* [FIX] password_security: Fix travis errors
alan196 pushed a commit to Jarsa/server-auth that referenced this pull request Jul 3, 2023
@lasley @dsolanki-initos
[9.0][ADD] Password Security Settings (OCA#531)
578c121 
* [ADD] res_users_password_security: New module
* Create new module to lock down user passwords

* [REF] res_users_password_security: PR Review fixes
* Also add beta pass history rule

* [ADD] res_users_password_security: Pass history and min time
* Add pass history memory and threshold
* Add minimum time for pass resets through web reset

* Begin controller tests

* Fix copyright, wrong year for new file

* Add tests for password_security_home
* Left to do web_auth_reset_password

* Fix minimum reset threshold and finish tests

* Bug fixes per review

* [REF] password_security: PR review improvements
* Change tech name to password_security
* Use new except format
* Limit 1 & new api
* Cascade deletion for pass history

* [REF] password_security: Fix travis + style
* Fix travis errors
* self to cls
* Better variable names in tests

* [FIX] password_security: Fix travis errors
@dreispt
Copy link
Member

dreispt commented Jul 12, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-531-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 12, 2023
@OCA-git-bot
Merge PR #531 into 14.0
fa2e45c 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-531-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul
Copy link
Member Author

sbidoul commented Jul 17, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-531-by-sbidoul-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 17, 2023
@OCA-git-bot
Merge PR #531 into 14.0
bf12ba6 
Signed-off-by sbidoul
@sbidoul
Copy link
Member Author

sbidoul commented Jul 17, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-531-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a4ca52a into OCA:14.0 Jul 17, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e0e13aa. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 14.0-520-port branch July 17, 2023 09:29
jeroenev pushed a commit to jeroenev/server-auth that referenced this pull request Nov 30, 2023
@lasley
[9.0][ADD] Password Security Settings (OCA#531)
04841dd 
* [ADD] res_users_password_security: New module
* Create new module to lock down user passwords

* [REF] res_users_password_security: PR Review fixes
* Also add beta pass history rule

* [ADD] res_users_password_security: Pass history and min time
* Add pass history memory and threshold
* Add minimum time for pass resets through web reset

* Begin controller tests

* Fix copyright, wrong year for new file

* Add tests for password_security_home
* Left to do web_auth_reset_password

* Fix minimum reset threshold and finish tests

* Bug fixes per review

* [REF] password_security: PR review improvements
* Change tech name to password_security
* Use new except format
* Limit 1 & new api
* Cascade deletion for pass history

* [REF] password_security: Fix travis + style
* Fix travis errors
* self to cls
* Better variable names in tests

* [FIX] password_security: Fix travis errors
beagle-cloud pushed a commit to DynAppsNV/server-auth that referenced this pull request Jan 31, 2024
@lasley
[9.0][ADD] Password Security Settings (OCA#531)
3ae181c 
* [ADD] res_users_password_security: New module
* Create new module to lock down user passwords

* [REF] res_users_password_security: PR Review fixes
* Also add beta pass history rule

* [ADD] res_users_password_security: Pass history and min time
* Add pass history memory and threshold
* Add minimum time for pass resets through web reset

* Begin controller tests

* Fix copyright, wrong year for new file

* Add tests for password_security_home
* Left to do web_auth_reset_password

* Fix minimum reset threshold and finish tests

* Bug fixes per review

* [REF] password_security: PR review improvements
* Change tech name to password_security
* Use new except format
* Limit 1 & new api
* Cascade deletion for pass history

* [REF] password_security: Fix travis + style
* Fix travis errors
* self to cls
* Better variable names in tests

* [FIX] password_security: Fix travis errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sbidoul @dreispt @OCA-git-bot @lmignon @hparfr