Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] base_future_response #2660

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jun 23, 2023

This is a backport of Odoo 16 request.future_response mechanism, to allow
setting cookies in the response before the response object is constructed.

@sbidoul sbidoul added this to the 14.0 milestone Jun 23, 2023
@sbidoul sbidoul changed the title [ADD] base_future_response [14.0][ADD] base_future_response Jun 23, 2023
@sbidoul
Copy link
Member Author

sbidoul commented Jun 28, 2023

@lmignon would you like to review this one?

For better compatibility with many other modules
that monkey patch get_request.
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@sbidoul
Copy link
Member Author

sbidoul commented Jun 29, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2660-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 01272c6 into OCA:14.0 Jun 29, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0448a1c. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 14.0-base_future_response-sbi branch June 29, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants