Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] base_translation_field_label #2689

Merged
merged 6 commits into from
Aug 7, 2023
Merged

[15.0][MIG] base_translation_field_label #2689

merged 6 commits into from
Aug 7, 2023

Conversation

JasminSForgeFlow
Copy link
Contributor

Standard Migration

@ForgeFlow

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-base_translation_field_label branch from b1b20f4 to 318f99f Compare July 28, 2023 11:35
@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-base_translation_field_label branch from 318f99f to e0fa9d0 Compare July 28, 2023 11:36
GuillemCForgeFlow
GuillemCForgeFlow suggested changes Jul 28, 2023
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that tests are failing because it doesn't find the language used on the test. Perhaps we need to unarchive it first on the test so it can be found.

@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-base_translation_field_label branch from e0fa9d0 to 3654424 Compare July 31, 2023 04:08
@JasminSForgeFlow
Copy link
Contributor Author

I see that tests are failing because it doesn't find the language used on the test. Perhaps we need to unarchive it first on the test so it can be found.

Its done,
Thanks

GuillemCForgeFlow
GuillemCForgeFlow approved these changes Jul 31, 2023
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽

JordiMForgeFlow
JordiMForgeFlow approved these changes Aug 7, 2023
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + functional review 👍🏼

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

LoisRForgeFlow
LoisRForgeFlow approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration base_translation_field_label

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 7, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 14, 2023
Open
54 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-2689-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2a203ed into OCA:15.0 Aug 7, 2023
8 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 747bc0d. Thanks a lot for contributing to OCA. ❤️

@GuillemCForgeFlow GuillemCForgeFlow deleted the 15.0-mig-base_translation_field_label branch August 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JasminSForgeFlow @OCA-git-bot @LoisRForgeFlow @JordiMForgeFlow @GuillemCForgeFlow