Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[160][FIX] auditlog: prevent removal of x2many values from inaccessible companies #2814

Merged

Conversation

StefanRijnhart
Copy link
Member

Having a product.template with taxes from multiple companies assigned, let a user without all of these companies enabled set the taxes of that product.

Before this change, the taxes related to inaccessible companies will be inadvertently removed.

Based on #2628 by @rven

@StefanRijnhart StefanRijnhart added this to the 16.0 milestone Jan 19, 2024
@StefanRijnhart StefanRijnhart changed the title [FIX] auditlog: prevent removal of x2many values from inaccessible companies [160][FIX] auditlog: prevent removal of x2many values from inaccessible companies Jan 19, 2024
…mpanies

Having a product.template with taxes from multiple companies assigned, let a
user without all of these companies enabled set the taxes of that product.

Before this change, the taxes related to inaccessible companies will be
inadvertently removed.

Co-authored-by: Raf Ven <[email protected]>
@StefanRijnhart StefanRijnhart force-pushed the 16.0-auditlog-fix-multicompany-values branch from 46965a9 to da9928d Compare January 19, 2024 19:12
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I reviewed the code (big thanks for the test) and verified locally that the issue is fixed.

auditlog/models/rule.py Show resolved Hide resolved
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2814-by-thomaspaulb-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa242cb into OCA:16.0 Feb 2, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4b4eb6c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants