-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[160][FIX] auditlog: prevent removal of x2many values from inaccessible companies #2814
[160][FIX] auditlog: prevent removal of x2many values from inaccessible companies #2814
Conversation
…mpanies Having a product.template with taxes from multiple companies assigned, let a user without all of these companies enabled set the taxes of that product. Before this change, the taxes related to inaccessible companies will be inadvertently removed. Co-authored-by: Raf Ven <[email protected]>
46965a9
to
da9928d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I reviewed the code (big thanks for the test) and verified locally that the issue is fixed.
This PR has the |
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 4b4eb6c. Thanks a lot for contributing to OCA. ❤️ |
Having a product.template with taxes from multiple companies assigned, let a user without all of these companies enabled set the taxes of that product.
Before this change, the taxes related to inaccessible companies will be inadvertently removed.
Based on #2628 by @rven