Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] onchange_helper: Migration to 18.0 #3052

Merged
merged 54 commits into from
Oct 10, 2024

Conversation

thienvh332
Copy link

No description provided.

florian-dacosta and others added 30 commits October 8, 2024 12:15
other improvement:

set onchange_specs to all fields as _onchange_spec()
retrun onchange fields for default view
return field value if it's set in onchange_fields (usuful to get default value for a field)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-onchange_helper/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-tools-12.0/server-tools-12.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-onchange_helper/zh_CN/
weblate and others added 16 commits October 8, 2024 12:15
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-onchange_helper/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-tools-16.0/server-tools-16.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-onchange_helper/es/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-tools-16.0/server-tools-16.0-onchange_helper
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-onchange_helper/it/
Without explicit web dependency all tests fail like this:

File "/home/odoo/src/odoo/odoo/models.py", line 6905, in onchange
    raise NotImplementedError("onchange() is implemented in module 'web'")
NotImplementedError: onchange() is implemented in module 'web'
…ed by

As the onchange method can be a little bulky, we don't call it if fields passed as
arguments are not in _onchange_methods
@thienvh332 thienvh332 marked this pull request as ready for review October 8, 2024 05:24
@thienvh332 thienvh332 mentioned this pull request Oct 8, 2024
21 tasks
@simahawk
Copy link
Contributor

simahawk commented Oct 9, 2024

/ocabot migration onchange_helper

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 9, 2024
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3052-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 10, 2024
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-3052-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 48aba72 into OCA:18.0 Oct 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e2b7cfa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.