Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WMS][12.0] Add stock_picking_completion_info - alpha version #693

Merged

Conversation

grindtildeath
Copy link
Contributor

@grindtildeath grindtildeath commented Sep 2, 2019

This module adds completion information on stock picking.

If activated on the picking type, completion information is computed according
to the next chained pickings related to the stock moves of the actual picking.

In other words, if all the previous moves linked to the destination pickings
moves are done, the completion of the actual picking allows the destination
pickings to be processed. In such case, a ribbon will appear on the stock
picking form view, to inform the stock operator.

Relates to #640 (comment)

@grindtildeath grindtildeath force-pushed the 12.0_add_stock_picking_completion_info branch from 89f95f9 to 56d5540 Compare September 2, 2019 13:52
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I see here it looks good. Minor spelling proposal.

Then to truly test this we need to merge it as alpha alongside with picking_zone #639

stock_picking_completion_info/__manifest__.py Outdated Show resolved Hide resolved
stock_picking_completion_info/models/stock_picking.py Outdated Show resolved Hide resolved
stock_picking_completion_info/models/stock_picking.py Outdated Show resolved Hide resolved
stock_picking_completion_info/models/stock_picking.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Tonow-c2c Tonow-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just question but LGTM

stock_picking_completion_info/__manifest__.py Show resolved Hide resolved
stock_picking_completion_info/models/stock_picking.py Outdated Show resolved Hide resolved
@jgrandguillaume
Copy link
Member

Hi @grindtildeath

After several tests, I have one remaining issue, all the rest is working fine.

Step to reproduce:

  • Install module stock_picking_zone
  • Set as pick+ pack+ship
  • Locations
    • Stock
      • Zone 1
      • Zone 2
  • Create new Picking type
    • name = Zone 1, type is_zone=True, default src destination= Zone 1, default destination = packing
  • Make an inventory in Zone 1 and Zone with some products
  • Create an order with product in Zone 1 and 2 and confirm
  • Generate:
    • Zone 1 Pick with the products in zone 1
    • Pick for the products in zone 2
  • Process the pick

Here it is supposed to say that it is NOT a complete order. It seems it doesn't look correctly in the following moves in such a case. In the packing operation, I have moves from both zone 1 and 2. So none of the picking operation should display that it is a complete order.

Call me if not clear.

@rousseldenis
Copy link
Contributor

@grindtildeath What's the status of this ?

manuelcalerosolis pushed a commit to xtendoo-corporation/stock-logistics-warehouse that referenced this pull request Oct 31, 2020
Signed-off-by guewen
@dreispt
Copy link
Member

dreispt commented Mar 9, 2021

/ocabot merge nobump

OCA-git-bot added a commit that referenced this pull request Mar 9, 2021
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-693-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-693-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 27c5244 into OCA:12.0 Mar 10, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3ba275. Thanks a lot for contributing to OCA. ❤️

@rousseldenis
Copy link
Contributor

rousseldenis commented Mar 10, 2021

@dreispt I think this could have been improved (squash), one question remained unanswered.

What was the emergency of massive merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants