[MIG][13.0] stock_picking_completion_info #808

guewen · 2019-12-19T14:04:44Z

Port #693
Depends on #861

grindtildeath · 2020-03-11T10:43:10Z

We should probably rework this module to depend on #861

simahawk · 2020-03-16T16:06:43Z

@guewen any feedback?

guewen · 2020-03-17T11:02:55Z

@simahawk well, @grindtildeath knows better, he wrote this module :)

grindtildeath · 2020-03-23T10:43:40Z

stock_picking_completion_info/models/stock_picking.py

+
+    @api.depends(
+        "picking_type_id.display_completion_info",
+        "move_lines.move_dest_ids.move_orig_ids.state",


Wrong dependency (cf line 53)

grindtildeath · 2020-04-06T14:29:38Z

@guewen Can you please merge guewen#8 ?

Maybe also add module dependency #861 in the PR description?

Tonow-c2c · 2020-04-14T06:38:28Z

@guewen did you enough right to restart travis ?

simahawk · 2020-04-14T06:45:45Z

@grindtildeath if you have time and you want to finish this, please take it over because Guewen is on holidays for 1 week 😉

grindtildeath · 2020-04-21T07:55:30Z

@simahawk @guewen Seems we only need a rebase here, and it should be fine...

guewen · 2020-04-24T09:10:02Z

Rebased

simahawk · 2020-04-24T09:46:04Z

@guewen is 🔴

rousseldenis · 2020-04-24T09:48:39Z

stock_picking_completion_info/models/stock_picking.py

+        if "state" in vals:
+            # invalidate cache, the api.depends do not allow to find all
+            # the conditions to invalidate the field
+            self.env["stock.picking"].invalidate_cache(fnames=["completion_info"])


Is it real or is it the behaviour you have in tests ? If it is just in tests, do the invalidate_cache() there and not here.

I don't have an issue running the tests without this override, @guewen might know better.

I think it was not only in tests, IIRC the dependencies in @api.depends() of the computed field could not be triggered in every case in chained moves. But maybe now that we have "move_lines.common_dest_move_ids.state", in the dependencies it's no longer the case and this could be removed?

guewen · 2020-04-24T09:51:40Z

@grindtildeath tests fail after de4dcfd, can you have a look?

grindtildeath · 2020-04-24T11:18:52Z

@guewen should be fixed with guewen#10

In this module: OCA#808 A computed field uses "common_dest_move_ids" as dependency: @api.depends( "picking_type_id.display_completion_info", "move_lines.common_dest_move_ids.state", ) def _compute_completion_info(self): Which has the following effect when the ORM triggers changes: odoo.osv.expression: Non-stored field stock.move.common_dest_move_ids cannot be searched. Implement a search method to prevent this.

The version of stock_move_common_dest installed by pip misses a correction done in OCA/stock-logistics-warehouse#808

jgrandguillaume

LGTM

jgrandguillaume · 2020-05-28T19:08:21Z

/ocabot merge

OCA-git-bot · 2020-05-28T19:08:22Z

Hi @jgrandguillaume. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

ocabot merge major|minor|patch|nobump

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

OCA-git-bot · 2020-05-28T19:34:53Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

guewen · 2020-07-17T06:50:27Z

/ocabot merge minor

OCA-git-bot · 2020-07-17T06:50:39Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-808-by-guewen-bump-minor, awaiting test results.

OCA-git-bot · 2020-07-17T07:26:08Z

Congratulations, your PR was merged at 7b419fc. Thanks a lot for contributing to OCA. ❤️

The version of stock_move_common_dest installed by pip misses a correction done in OCA/stock-logistics-warehouse#808

In this module: OCA#808 A computed field uses "common_dest_move_ids" as dependency: @api.depends( "picking_type_id.display_completion_info", "move_lines.common_dest_move_ids.state", ) def _compute_completion_info(self): Which has the following effect when the ORM triggers changes: odoo.osv.expression: Non-stored field stock.move.common_dest_move_ids cannot be searched. Implement a search method to prevent this.

Signed-off-by guewen

In this module: OCA#808 A computed field uses "common_dest_move_ids" as dependency: @api.depends( "picking_type_id.display_completion_info", "move_lines.common_dest_move_ids.state", ) def _compute_completion_info(self): Which has the following effect when the ORM triggers changes: odoo.osv.expression: Non-stored field stock.move.common_dest_move_ids cannot be searched. Implement a search method to prevent this.

Signed-off-by guewen

In this module: OCA#808 A computed field uses "common_dest_move_ids" as dependency: @api.depends( "picking_type_id.display_completion_info", "move_lines.common_dest_move_ids.state", ) def _compute_completion_info(self): Which has the following effect when the ORM triggers changes: odoo.osv.expression: Non-stored field stock.move.common_dest_move_ids cannot be searched. Implement a search method to prevent this.

In this module: OCA/stock-logistics-warehouse#808 A computed field uses "common_dest_move_ids" as dependency: @api.depends( "picking_type_id.display_completion_info", "move_lines.common_dest_move_ids.state", ) def _compute_completion_info(self): Which has the following effect when the ORM triggers changes: odoo.osv.expression: Non-stored field stock.move.common_dest_move_ids cannot be searched. Implement a search method to prevent this.

max3903 added this to the 13.0 milestone Dec 31, 2019

guewen force-pushed the 13.0-mig-stock_picking_completion_info branch from 1da0a07 to 60dbca0 Compare January 7, 2020 06:29

guewen force-pushed the 13.0-mig-stock_picking_completion_info branch from 60dbca0 to 88fd2e8 Compare March 17, 2020 11:04

grindtildeath reviewed Mar 23, 2020

View reviewed changes

grindtildeath and others added 6 commits April 24, 2020 11:08

12.0 create module stock picking completion info

03cc9da

Distinct full order picking

6c2d9f3

[IMP] stock_picking_completion_info: black, isort

071d70e

[MIG] stock_picking_completion_info: Migration to 13.0

0289d74

run pre-commit with new prettiers

a7dcbec

Rely on stock_move_common_dest as dependency

de4dcfd

guewen force-pushed the 13.0-mig-stock_picking_completion_info branch from a8245a7 to de4dcfd Compare April 24, 2020 09:09

rousseldenis reviewed Apr 24, 2020

View reviewed changes

grindtildeath approved these changes Apr 24, 2020

View reviewed changes

Fix tests after change in dependencies

ac9a241

guewen force-pushed the 13.0-mig-stock_picking_completion_info branch from 2bc27e0 to ac9a241 Compare April 27, 2020 09:32

simahawk mentioned this pull request May 6, 2020

Shopfloor detail refactor camptocamp/wms#9

Merged

guewen added a commit to camptocamp/wms that referenced this pull request May 6, 2020

Fix build

7a0855b

The version of stock_move_common_dest installed by pip misses a correction done in OCA/stock-logistics-warehouse#808

jgrandguillaume approved these changes May 28, 2020

View reviewed changes

OCA-git-bot added the approved label May 28, 2020

OCA-git-bot added the ready to merge label May 28, 2020

OCA-git-bot added the bot is merging ⏳ label Jul 17, 2020

OCA-git-bot merged commit 3ca206c into OCA:13.0 Jul 17, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 17, 2020

simahawk pushed a commit to simahawk/wms that referenced this pull request Oct 12, 2020

Fix build

96a7083

The version of stock_move_common_dest installed by pip misses a correction done in OCA/stock-logistics-warehouse#808

CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021

Merge PR OCA#808 into 13.0

8dae2df

Signed-off-by guewen

CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021

Merge PR OCA#808 into 13.0

57c0c1d

Signed-off-by guewen

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][13.0] stock_picking_completion_info #808

[MIG][13.0] stock_picking_completion_info #808

guewen commented Dec 19, 2019 •

edited

Loading

grindtildeath commented Mar 11, 2020

simahawk commented Mar 16, 2020

guewen commented Mar 17, 2020

grindtildeath Mar 23, 2020

grindtildeath commented Apr 6, 2020

Tonow-c2c commented Apr 14, 2020

simahawk commented Apr 14, 2020

grindtildeath commented Apr 21, 2020

guewen commented Apr 24, 2020

simahawk commented Apr 24, 2020

rousseldenis Apr 24, 2020

grindtildeath Apr 24, 2020

guewen Apr 24, 2020

guewen commented Apr 24, 2020 •

edited

Loading

grindtildeath commented Apr 24, 2020

jgrandguillaume left a comment

jgrandguillaume commented May 28, 2020

OCA-git-bot commented May 28, 2020

OCA-git-bot commented May 28, 2020

guewen commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

[MIG][13.0] stock_picking_completion_info #808

[MIG][13.0] stock_picking_completion_info #808

Conversation

guewen commented Dec 19, 2019 • edited Loading

grindtildeath commented Mar 11, 2020

simahawk commented Mar 16, 2020

guewen commented Mar 17, 2020

grindtildeath Mar 23, 2020

Choose a reason for hiding this comment

grindtildeath commented Apr 6, 2020

Tonow-c2c commented Apr 14, 2020

simahawk commented Apr 14, 2020

grindtildeath commented Apr 21, 2020

guewen commented Apr 24, 2020

simahawk commented Apr 24, 2020

rousseldenis Apr 24, 2020

Choose a reason for hiding this comment

grindtildeath Apr 24, 2020

Choose a reason for hiding this comment

guewen Apr 24, 2020

Choose a reason for hiding this comment

guewen commented Apr 24, 2020 • edited Loading

grindtildeath commented Apr 24, 2020

jgrandguillaume left a comment

Choose a reason for hiding this comment

jgrandguillaume commented May 28, 2020

OCA-git-bot commented May 28, 2020

OCA-git-bot commented May 28, 2020

guewen commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

OCA-git-bot commented Jul 17, 2020

guewen commented Dec 19, 2019 •

edited

Loading

guewen commented Apr 24, 2020 •

edited

Loading