[13.0] Add module stock_move_common_dest_sync_location - alpha #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guewen
reviewed
Mar 11, 2020
grindtildeath
force-pushed
the
13.0-add-stock_move_common_dest_sync_location
branch
from
fd188b9
to
f1feb56
Compare
In this module: OCA#808 A computed field uses "common_dest_move_ids" as dependency: @api.depends( "picking_type_id.display_completion_info", "move_lines.common_dest_move_ids.state", ) def _compute_completion_info(self): Which has the following effect when the ORM triggers changes: odoo.osv.expression: Non-stored field stock.move.common_dest_move_ids cannot be searched. Implement a search method to prevent this.
First big change is that now, the 'sync' flag has to be set on the "destination picking type", not the current one. When we want to "regroup" moves from different transfer to the same place for a packing, we want to activate this feature on the said packing operation type. Also, instead of changing the destination of move lines every time we change a move line, we change it the first time a move is set to done to go towards this location. We don't need to do it until the first line is effectively moved.
guewen
force-pushed
the
13.0-add-stock_move_common_dest_sync_location
branch
from
f1feb56
to
745b8fb
Compare
in stock_move_common_dest_sync_location Some notes: * syncing the destinations could not be done during _action_assign: if we call _action_done on several moves at once with different locations, we don't expect them to change of destination under the hood! So we sync after _action_done * For now, no code is needed in stock_dynamic_routing_common_dest_sync to make the modules compatibles, but it contains tests with routing + sync
guewen
force-pushed
the
13.0-add-stock_move_common_dest_sync_location
branch
from
93e448f
to
f5a0713
Compare
jgrandguillaume
approved these changes
May 4, 2020
We want the move to be as precise as the move line once selected, so for instance if we have: Packing Post Packing Post/Bay 1 Packing Post/Bay 2 When the first move is done using Packing Post/Bay 1, the moves must be updated with Packing Post/Bay 1, because if we have unavailable moves, we ensure that their move lines will be moved to Bay 1 once they become available.
guewen
requested changes
May 14, 2020
|
The replacement for this feature is #907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: