Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] stock_picking_back2draft #550

Merged
merged 7 commits into from
Sep 10, 2019
Merged

[11.0][MIG] stock_picking_back2draft #550

merged 7 commits into from
Sep 10, 2019

Conversation

AaronHForgeFlow
Copy link
Contributor

Nothing to do

@LoisRForgeFlow
Copy link
Contributor

v12 or v11? commit says 12 but is pointing to v11 branch.

@pedrobaeza
Copy link
Member

Why do you need this? Unlock the picking and modify whatever...

@pedrobaeza
Copy link
Member

In fact, this can lead to some inconsistencies in current flows.

@AaronHForgeFlow AaronHForgeFlow force-pushed the 11.0-mig-stock_pickingback2draft branch from da112c9 to d68fd4c Compare July 9, 2019 13:35
@rousseldenis
Copy link
Contributor

rousseldenis commented Jul 9, 2019 •
edited
Loading

@pedrobaeza In some situations, people cancelled pickings (manipulation error or ....). If you cannot set it back to draft, it is impossible easily to solve the situation

@pedrobaeza
Copy link
Member

OK, if you think there's no problem on this, go ahead.

@AaronHForgeFlow
Copy link
Contributor Author

v12 or v11? commit says 12 but is pointing to v11 branch.

v11? 😄

Why do you need this? Unlock the picking and modify whatever...

Hi @pedrobaeza I did not notice about that unlock option, is it standard?

In fact, this can lead to some inconsistencies in current flows.

Same as in previous versions of the module, but it helps to fix cancellation by mistake...

@pedrobaeza
Copy link
Member

Yes, the unlock option is standard. I don't remember if it's enabled by default or you need to enable it on the settings. But this option is on done pickings, not on cancelled ones.

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Aug 27, 2019
Merged
@rousseldenis rousseldenis added this to the 11.0 milestone Aug 27, 2019
@rousseldenis
Copy link
Contributor

@aheficent What's the status of this ?

@AaronHForgeFlow
Copy link
Contributor Author

@rousseldenis I think this is still ready to review. The objective of this module is to allow quick fixes by users when cancelling stock pickings, same as in previous versions. I think it is still valid.

@pedrobaeza pedrobaeza mentioned this pull request Sep 10, 2019
Closed
45 tasks
rousseldenis
rousseldenis approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

HaraldPanten
HaraldPanten approved these changes Sep 10, 2019
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot. Functional review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-550-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 10, 2019
@OCA-git-bot
Merge PR #550 into 11.0
81c9740 
Signed-off-by rousseldenis
@OCA-git-bot OCA-git-bot merged commit ea34d4a into OCA:11.0 Sep 10, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d30d67d. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-mig-stock_pickingback2draft branch September 12, 2019 13:19
sebalix pushed a commit to sebalix/stock-logistics-workflow that referenced this pull request Oct 10, 2019
@LoisRForgeFlow
Merge pull request OCA#550 from kittiu/12.0-mig-stock_orderpoint_move…
25cc9b6 
…_link

[12.0][MIG] stock_orderpoint_move_link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@robyf70 robyf70 robyf70 approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.