Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] stock_picking_back2draft #560

Merged
merged 7 commits into from
Sep 10, 2019
Merged

[12.0][MIG] stock_picking_back2draft #560

merged 7 commits into from
Sep 10, 2019

Conversation

robyf70
Copy link
Contributor

@robyf70 robyf70 commented Aug 27, 2019

Just migrated the module to v12

@rousseldenis rousseldenis added this to the 12.0 milestone Aug 27, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 27, 2019
Open
34 tasks
@LoisRForgeFlow
Copy link
Contributor

Please preserve commit history: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0#technical-method-to-migrate-a-module-from-110-to-120-branch

Also your review in v11 would be much appreciated to move things faster: #550

@robyf70
Copy link
Contributor Author

robyf70 commented Aug 27, 2019

Please preserve commit history: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0#technical-method-to-migrate-a-module-from-110-to-120-branch

Ok! I'm going to push it

Also your review in v11 would be much appreciated to move things faster: #550

Sure! Will do right now

@robyf70 robyf70 force-pushed the 12.0-mig-stock_picking_back2draft branch from 1c1bc99 to d8ab5f8 Compare August 27, 2019 15:34
@robyf70 robyf70 force-pushed the 12.0-mig-stock_picking_back2draft branch from d8ab5f8 to 00a204e Compare September 6, 2019 15:16
HaraldPanten
HaraldPanten approved these changes Sep 9, 2019
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

@HaraldPanten
Copy link

Hi @rousseldenis I think this PR is on the same status as #550

AaronHForgeFlow
AaronHForgeFlow reviewed Sep 10, 2019
View reviewed changes
stock_picking_back2draft/__manifest__.py
"summary": "Reopen cancelled pickings",
"version": "12.0.1.0.0",
"category": "Warehouse Management",
"website": "https://www.agilebg.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'website': 'https://github.com/OCA/stock-logistics-workflow',

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-560-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 10, 2019
@OCA-git-bot
Merge PR #560 into 12.0
da53a5a 
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 12.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 12.0-ocabot-merge-pr-560-by-rousseldenis-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 10, 2019
@OCA-git-bot
Merge PR #560 into 12.0
8a0dd7b 
Signed-off-by rousseldenis
@OCA-git-bot OCA-git-bot merged commit 00a204e into OCA:12.0 Sep 10, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5b3b60c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow left review comments

@rousseldenis rousseldenis rousseldenis approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
10 participants
@robyf70 @LoisRForgeFlow @HaraldPanten @OCA-git-bot @rousseldenis @AaronHForgeFlow @eLBati @oca-transbot @sbidoul @oca-travis