Re #2361: fix seg combobox filling

[Punzo]

Fix #2361

dataset:
http://localhost:3000/projects/idc-dev-etl/locations/us-central1/datasets/idc_tcia_dev/dicomStores/idc_tcia/study/1.3.6.1.4.1.14519.5.2.1.7695.2311.111788911924319643511738623890

[codecov]

Codecov Report

Merging #2369 (21a5d1b) into master (f85f856) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
- Coverage   13.50%   13.30%   -0.21%     
==========================================
  Files         287      287              
  Lines        7485     7590     +105     
  Branches     1414     1441      +27     
==========================================
- Hits         1011     1010       -1     
- Misses       5254     5333      +79     
- Partials     1220     1247      +27     

Impacted Files	Coverage Δ
...latform/core/src/classes/metadata/StudyMetadata.js	1.36% <0.00%> (-0.29%)	⬇️
...m/core/src/utils/loadAndCacheDerivedDisplaySets.js	0.00% <0.00%> (-2.86%)	⬇️
...viewer/src/components/ViewportGrid/ViewportGrid.js	0.00% <0.00%> (ø)
...r/src/connectedComponents/ConnectedStudyBrowser.js	0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js	0.00% <0.00%> (ø)
...tform/viewer/src/connectedComponents/ViewerMain.js	0.00% <0.00%> (ø)
...src/connectedComponents/ViewerRetrieveStudyData.js	0.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e75b0...21a5d1b. Read the comment docs.

[igoroctaviano]

http://localhost:3000/projects/idc-dev-etl/locations/us-central1/datasets/idc_tcia_dev/dicomStores/idc_tcia/study/1.3.6.1.4.1.14519.5.2.1.7695.2311.111788911924319643511738623890

2 issues:

• When selecting the second segmentation and going back to the first one the dropdown doesn't update.
• Invalid date in dropdown item.

[Punzo]

http://localhost:3000/projects/idc-dev-etl/locations/us-central1/datasets/idc_tcia_dev/dicomStores/idc_tcia/study/1.3.6.1.4.1.14519.5.2.1.7695.2311.111788911924319643511738623890

2 issues:

• When selecting the second segmentation and going back to the first one the dropdown doesn't update.

Fixed

• Invalid date in dropdown item.

This is not a bug, the metadata are missing the dates.

I have updated the PR, please review again, thanks!

[igoroctaviano]

Just retested, found some issues...

• Invalid date:
  
• Segmentation option with no segments when selecting a segmentation in the dropdown and then clicking other series with no segmentation:
  

[Punzo]

Just retested, found some issues...

• Invalid date:
  

This is not a bug (see also #2369 (comment)), all the segmentation series of this study miss the series time and date. So returning Invalid date is right.

• Segmentation option with no segments when selecting a segmentation in the dropdown and then clicking other series with no segmentation:
  

This is a bug in the react select element, see JedWatson/react-select#3066. I.e. undefined values do not clear the combobox, but only null. I fixed it in by forcing null if undefined is detected:
Fixed in 21a5d1b

[igoroctaviano]

LGTM!