-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re #2361: fix seg combobox filling #2369
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2369 +/- ##
==========================================
- Coverage 13.50% 13.30% -0.21%
==========================================
Files 287 287
Lines 7485 7590 +105
Branches 1414 1441 +27
==========================================
- Hits 1011 1010 -1
- Misses 5254 5333 +79
- Partials 1220 1247 +27
Continue to review full report at Codecov.
|
2 issues:
|
Fixed
This is not a bug, the metadata are missing the dates. I have updated the PR, please review again, thanks! |
This is not a bug (see also #2369 (comment)), all the segmentation series of this study miss the series time and date. So returning Invalid date is right. This is a bug in the react select element, see JedWatson/react-select#3066. I.e. undefined values do not clear the combobox, but only null. I fixed it in by forcing null if undefined is detected: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fix #2361
dataset:
http://localhost:3000/projects/idc-dev-etl/locations/us-central1/datasets/idc_tcia_dev/dicomStores/idc_tcia/study/1.3.6.1.4.1.14519.5.2.1.7695.2311.111788911924319643511738623890