Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump deps #109

Merged
merged 2 commits into from
Sep 27, 2024
Merged

chore: bump deps #109

merged 2 commits into from
Sep 27, 2024

Conversation

Enter-tainer
Copy link
Member

No description provided.

@Enter-tainer Enter-tainer marked this pull request as ready for review September 27, 2024 07:12
@shaokeyibb
Copy link
Member

vitest 我记得是不能更新的，wrangler 强制依赖一个固定版本的 vitest 才能跑

@Enter-tainer
Copy link
Member Author

@shaokeyibb 为啥呀，但是现在看起来ci也跑过了？

@shaokeyibb
Copy link
Member

https://developers.cloudflare.com/workers/testing/vitest-integration/get-started/write-your-first-test/

这上面说目前只能用 Vitest 2.0.5（之前是1.5.0），CI 确实过了但是不太好说以后会不会有隐性的 bug?

@Enter-tainer
Copy link
Member Author

https://github.com/cloudflare/workers-sdk/blob/01956212410d6cd43419754028b018cfa5039add/packages/vitest-pool-workers/CHANGELOG.md?plain=1#L62 似乎是文档没更新？changelog里面写支持 2.1.x

@Enter-tainer
Copy link
Member Author

cloudflare/workers-sdk#6716

@shaokeyibb
Copy link
Member

🤔好吧，那应该可以

@Enter-tainer Enter-tainer merged commit 26549e6 into master Sep 27, 2024
5 checks passed
@Enter-tainer Enter-tainer deleted the mgt/update-deps branch September 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaokeyibb shaokeyibb shaokeyibb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enter-tainer @shaokeyibb