Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for vitest 2.1.x #6716

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

Cherry
Copy link
Contributor

@Cherry Cherry commented Sep 14, 2024

What this PR solves / how to test

Adds support for Vitest 2.1.x, and bumps create-cloudflare templates to pull the new version. No code changes required my testing, so this is primarily just extending the supported version range.

I fixed up a few tests now that Vitest doesn't allow toMatchInlineSnapshot being called multiple times, but I'm not sure why the cloudchamber tests are failing.

Fixes #6717

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: No functional changes, just dep bumps
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: No functional changes, just dep bumps
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No functional changes, just dep bumps

Copy link

changeset-bot bot commented Sep 14, 2024

🦋 Changeset detected

Latest commit: d09512f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-wrangler-6716

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6716/npm-package-wrangler-6716

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-wrangler-6716 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-create-cloudflare-6716 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-cloudflare-kv-asset-handler-6716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-miniflare-6716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-cloudflare-pages-shared-6716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-cloudflare-vitest-pool-workers-6716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-cloudflare-workers-editor-shared-6716
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10883652267/npm-package-cloudflare-workers-shared-6716

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.1
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Cherry Cherry marked this pull request as ready for review September 14, 2024 14:28
@Cherry Cherry requested review from a team as code owners September 14, 2024 14:28
@penalosa penalosa mentioned this pull request Sep 16, 2024
12 tasks
@penalosa
Copy link
Contributor

This is passing everything but the C3 E2E tests, which are not intended to run on forks. We've got a bug with that logic, it seems—but in the meantime I'll merge this.

@penalosa penalosa merged commit 321a9e1 into cloudflare:main Sep 16, 2024
20 of 24 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Sep 16, 2024
Copy link

holopin-bot bot commented Sep 16, 2024

Congratulations @Cherry, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm152is6t68880cle8rjyw4gb

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Add support for Vitest 2.1.x
3 participants