-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua in ingress-nginx #13
Comments
OK, that looks like it's gonna continue to work. But actually because of this mechanism I see problems that we can actually use this setup. Would it be possible to maybe have a "regular" nginx as a Deployment which receives the traffic from the "untouched" ingress controller (which could be nginx-ingress, HA proxy, ...) For example Grafana Mimir also ships a NGINX deployment for similar functionality like you have it for OnlyOffice, see https://github.com/grafana/mimir/tree/main/operations/helm/charts/mimir-distributed/templates/gateway |
sorry for be intrusive, but I would love to know how kubernetes/ingress-nginx#11819 will impact you folks :) Can you please provide some feedback on some features we are marking to deprecate as well? thanks |
Please specify if you have already looked through this section of the article where the usage of already set nginx-ingress controller is mentioned. Please let me know what you think about it.
Our Nginx Ingress Controller based load balancing uses the built-in mechanism for obtaining DS replica endpoints and our lua proxy script based on a request argument. We require to consider and implement such a mechanism when we are talking about "regular" nginx.
We checked the deployment with enabled
Unfortunately, we saw only few of them, do you have a list of the features you are going to mark to deprecate in the future releases, so to say "a to-do" list? |
@rikatz, thanks for pointing it out for us again, we can confirm that the changes to be added in the next release will not affect our chart. We will track the future changes as well to make sure everything will works from our end. |
Honestly I'd still prefer a more self contained solution like described in #13 (comment):
With the current solution, how can I deploy OnlyOffice on a cluster:
|
@wkloucek, thank you for the feedback.
We discussed your suggestion and we are considering adding some autonomous load balancing service behind the Ingress Controller. As of now I can say for sure that the changes made to the balancer should not affect access via the Ingress to other applications. Regarding your questions, please find the answers below:
The currently installed version will not work without the access to management (update) of the already installed Ingress Controller.
Right now current iteration supports only Nginx Ingress Controller, please refer to this link https://github.com/ONLYOFFICE/Kubernetes-Docs-Shards?tab=readme-ov-file#4-configure-dependent-charts
There are might be problems with non-WOPI (standard API) integration on the current deployment as of now. We will check how they can be overcome. |
I saw that you're making use of lua plugins in:
Kubernetes-Docs-Shards/sources/ingress_values.yaml
Lines 7 to 9 in 0297dcb
According to kubernetes/ingress-nginx#10186 / kubernetes/ingress-nginx#11821 third party support for Lua plugins is gonna be removed from ingress-nginx.
Does affect this chart and how can it be mitigated? Maybe use a standalone nginx and not a ingress-nginx based nginx?
The text was updated successfully, but these errors were encountered: