-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3rd party lua plugin support #11821
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
f442836
to
b69a5d5
Compare
/priority important-longterm |
b69a5d5
to
a3b0a87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
I'm not sure what the versioning algorithm is for ingress-nginx, but as an end user, I'd kinda hope this results in at least a minor, if not a major version bump. |
@jsoref it will be on v1.12 (minor, as Kubernetes does), but not a patch release. |
does it mean, we will not able to use Lua Script in NGINX anymore? |
Not 3rd party, unless you modify the docker image and template |
What this PR does / why we need it:
For the sake of maintenance and security, we should stop allowing ingress-nginx to support 3rd party plugins and lua scripts.
We are aiming to have a much simpler implementation, and this PR removes this support