Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#646 remove init #741

Merged
merged 8 commits into from
Feb 28, 2023
Merged

#646 remove init #741

merged 8 commits into from
Feb 28, 2023

Conversation

nimshi89
Copy link
Contributor

Removing the imports from the init files

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

ubuntu-latest-python3.9 test results

476 tests  +1   476 ✔️ +1   3m 10s ⏱️ -8s
    9 suites ±0       0 💤 ±0 
    9 files   ±0       0 ❌ ±0 

Results for commit 7950764. ± Comparison against base commit 1726bab.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

ubuntu-latest-python3.11 test results

476 tests  +1   476 ✔️ +1   2m 57s ⏱️ -18s
    9 suites ±0       0 💤 ±0 
    9 files   ±0       0 ❌ ±0 

Results for commit 7950764. ± Comparison against base commit 1726bab.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2023 •
edited
Loading

windows-latest-python3.11 test results

  10 files  ±0    11 suites  ±0   8m 38s ⏱️ - 1m 14s
490 tests +1  490 ✔️ +1  0 💤 ±0  0 ❌ ±0 
503 runs  +1  503 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 7950764. ± Comparison against base commit 1726bab.

♻️ This comment has been updated with latest results.

robons
robons reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@robons robons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bring the comments back and I'll be happy to approve.

src/csvcubed/readers/__init__.py Outdated Show resolved Hide resolved
src/csvcubed/models/rdf/__init__.py Outdated Show resolved Hide resolved
src/csvcubed/utils/__init__.py Outdated Show resolved Hide resolved
src/csvcubed/utils/qb/__init__.py Outdated Show resolved Hide resolved
tests/__init__.py Show resolved Hide resolved
src/csvcubed/utils/sparql_handler/__init__.py Outdated Show resolved Hide resolved
src/csvcubed/utils/validators/__init__.py Outdated Show resolved Hide resolved
src/csvcubed/writers/__init__.py Outdated Show resolved Hide resolved
@nimshi89 nimshi89 marked this pull request as ready for review February 28, 2023 08:24
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nimshi89 nimshi89 merged commit 24106ab into main Feb 28, 2023
@nimshi89 nimshi89 deleted the #646_remove_init branch February 28, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robons robons robons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimshi89 @robons