database/raft: save snapshot position first #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL. This is the 1.2.x version of #1312. |
Save the snapshot position to the WAL before saving the snapshot data to disk. On boot, we open the WAL at the most recently saved snapshot's position. If we don't save the position to the WAL first, we might open the WAL at a snapshot position that was never saved to the WAL. We might want to wait until the CoreOS folks confirm this in etcd-io/etcd#8082. Also, it's debatable whether this meets the requirements for a point release given that this bug has a very low probablity of surfacing. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save the snapshot position to the WAL before saving the snapshot data to
disk. On boot, we open the WAL at the most recently saved snapshot's
position. If we don't save the position to the WAL first, we might open
the WAL at a snapshot position that was never saved to the WAL.
This is a fix for the 1.2.x release line.
See etcd-io/etcd#8082, etcd-io/etcd#8088.