Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capabilities billing default_plan #426

Closed
soxofaan opened this issue Nov 2, 2021 · 5 comments · Fixed by #428
Closed

capabilities billing default_plan #426

soxofaan opened this issue Nov 2, 2021 · 5 comments · Fixed by #428
Assignees
Labels
Milestone

Comments

@soxofaan
Copy link
Member

soxofaan commented Nov 2, 2021

openeo-api/openapi.yaml

Lines 720 to 726 in f303d65

default_plan:
type: string
description: >-
Name of the default plan to use when the user doesn't
specify a plan or has no default plan has been assigned
for the user.
example: free

first, a small typo:

... or has no default plan has been assigned ...

While thinking about it, it seems this is not well defined yet:
Should the default plan be a paid or non-paid plan?
If it's a paid plan, then how can it be a default for free users?
If it's a non-paid plan, then it's not ideal to use as default for paying users (e.g. they get worse performance because they are not using their paid plan).

@soxofaan
Copy link
Member Author

soxofaan commented Nov 2, 2021

(related to #425 )

@m-mohr m-mohr added this to the 1.2.0 milestone Nov 2, 2021
@m-mohr m-mohr self-assigned this Nov 2, 2021
@m-mohr m-mohr added the bug label Nov 2, 2021
@soxofaan
Copy link
Member Author

soxofaan commented Nov 3, 2021

given #425 : maybe there should be no global default plan, and just a per user default plan (based on their subscription)?

m-mohr added a commit that referenced this issue Nov 4, 2021
@m-mohr m-mohr linked a pull request Nov 4, 2021 that will close this issue
@m-mohr
Copy link
Member

m-mohr commented Nov 4, 2021

I've tried to improve documentation in PR #428 based on the situation we have right now.

@jdries
Copy link

jdries commented Nov 5, 2021

I'm also really not sure that we'll end up with a notion of multiple billing plans per user.
There's also this vsc4 'plan', which is not really a billing plan but rather an entirely separate backend, which might even have specific capabilities.

@m-mohr
Copy link
Member

m-mohr commented Nov 5, 2021

Sure, but this is the general API so the option should be there anyway. Somewhat agree on vsc4. One the one hand it's a somewhat separate back-end, but on the other hand the billing plans were also meant to distinguish between different "configurations of hardware". So depends on a case by case basis.

m-mohr added a commit that referenced this issue Dec 15, 2021
* Clarify billing (default) plans #425 #426

* Updates after code review
@m-mohr m-mohr closed this as completed Dec 15, 2021
This was referenced May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants