Clarify (default) billing plans #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 4, 2021
This was referenced Nov 4, 2021
soxofaan
reviewed
Dec 8, 2021
openapi.yaml
Outdated
| Back-ends resolve billing plans in the following order: | ||
| 1. If provided, use the `plan` in the processing request. | ||
| 2. If provided, use the plan exposed here. | ||
| 3. Otherwise, use the `default_plan` exposed through `GET /`. |
There was a problem hiding this comment.
I'm not sure it's useful to explain this priority scheme here. I think it complicates the description unnecessarily. It's discussed in a more appropriate place already.
What could be useful to mention is whether a user can be subscribed to multiple plans (I think not, if I understand correctly).
Another subtlety is whether there is a difference between a missing "default_plan" or a "null" default plan (e.g. backend does not support plans vs user has no plan)
There was a problem hiding this comment.
- Agreed, removed the priority scheme.
- Clarified that only a single plan is supported.
- null: I think I can actually remove the nullable as it has the same meaning as "not present".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the situation around the issues raised in #425 and #426.