-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify zephyr MACHINE and map processor arm64 -> aarch64 #208
Conversation
33cfd97
to
589d777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go.
Thanks - I'm still doing some testing under arm and arm64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you just rename pool.c
to sys.c
that's metal_generic_default_poll
is define in sys.c for all platforms?
thanks
lib/system/zephyr/poll.c
Outdated
* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
*/ | ||
|
||
/* | ||
* @file zephyr/riscv/sys.c | ||
* @brief machine specific system primitives implementation. | ||
* @file zephyr/poll.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you keep sys.c to harmonize the file naming with other platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. force-pushed changes to rename poll.c to sys.c and update CMakeLists.txt accordingly.
(I can't believe that in 2022 github still can't track changes across force-pushes - other tools like gitlab have been doing this for years)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delta is visible by clicking on the compare button or the force_push ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, thanks! somehow I expected to see this under Files changed but it appears it's only visible in the PR "conversation". that's what I get for hanging out in gitlab for a while!
Please let me know when your tests are finished (maybe it is already finished). |
Replace the architecture-specific machine directories with a common C function for polling which calls to arch_cpu_idle. Add a special case to map Zephyr arm64 to libmetal aarch64 in defining PROJECT_PROCESSOR variable. Set the MACHINE variable based CONFIG_ARCH instead of testing individual arch config flags. Signed-off-by: Eugene Cohen <[email protected]>
This adds CI build test for arm64 architecture. Signed-off-by: Eugene Cohen <[email protected]>
589d777
to
1e915b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Replace the architecture-specific machine directories with a common
C function for polling which calls to arch_cpu_idle.
Add a special case to map Zephyr arm64 to libmetal aarch64 in defining
PROJECT_PROCESSOR variable.
Set the MACHINE variable based CONFIG_ARCH instead of testing
individual arch config flags.