Virtio exp #213
Closed
Virtio exp #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Guittot <[email protected]> Signed-off-by: Dan Milea <[email protected]>
Signed-off-by: Dan Milea <[email protected]>
Signed-off-by: Dan Milea <[email protected]>
Signed-off-by: Dan Milea <[email protected]>
arnopo
reviewed
Jun 2, 2022
| @@ -0,0 +1,5 @@ | |||
| collect (PROJECT_LIB_HEADERS sys.h) | |||
There was a problem hiding this comment.
#208 probably makes this patch obsolete
I can move the virtio_exp branch on top of it
| @@ -31,7 +31,7 @@ extern "C" { | |||
| } | |||
|
|
|||
| #ifndef METAL_MAX_DEVICE_REGIONS | |||
| #define METAL_MAX_DEVICE_REGIONS 1 | |||
| #define METAL_MAX_DEVICE_REGIONS 2 | |||
There was a problem hiding this comment.
This should be defined in zephyr. in prj.conf or in Cmakelists.txt
for instance: https://github.com/zephyrproject-rtos/zephyr/blob/main/samples/subsys/ipc/openamp_rsc_table/CMakeLists.txt#L15
| @@ -0,0 +1,14 @@ | |||
| # | |||
There was a problem hiding this comment.
This one is OK for the virtio_exp branch to avoid to fork the zephyrproject-rtoss/open-amp and zephyrproject-rtos/libmetal repos.
Please, could you add the information in commit subject
| @@ -0,0 +1 @@ | |||
| aarch64 | |||
There was a problem hiding this comment.
should also be addressed in #208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
virtio-mmio framework for libmetal / open-amp