Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warn: declaration of 'vring_rsc' shadows a previous local #439

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix warn: declaration of 'vring_rsc' shadows a previous local #439

merged 1 commit into from
Nov 14, 2022

Conversation

xiaoxiang781216
Copy link
Collaborator

@xiaoxiang781216 xiaoxiang781216 commented Nov 6, 2022 •
edited
Loading 

 regressed by commit 03c80a13417f67f94852cf7d5cb160f1bdf8271e
    Author: Tammy Leino <[email protected]>
    Date:   Mon Sep 26 08:14:35 2022 -0700
    
        handle_vdev_rsc must return error if notifyid cannot be assigned
    
        Updated handle_vdev_rsc to return error if a unique id cannot be assigned
        Signed-off-by: Tammy Leino <[email protected]>

@xiaoxiang781216
Fix warn: declaration of 'vring_rsc' shadows a previous local
1dc36d5 
regressed by commit 03c80a1
Author: Tammy Leino <[email protected]>
Date:   Mon Sep 26 08:14:35 2022 -0700

    handle_vdev_rsc must return error if notifyid cannot be assigned

    Updated handle_vdev_rsc to return error if a unique id cannot be assigned
    Signed-off-by: Tammy Leino <[email protected]>

Signed-off-by: Xiang Xiao <[email protected]>
arnopo
arnopo approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks!
We need to add add the -Wshadow build flag in our test environment

@arnopo arnopo requested a review from edmooring November 7, 2022 13:29
@arnopo arnopo mentioned this pull request Nov 7, 2022
Merged
@arnopo arnopo added this to the Release V2023.04 milestone Nov 7, 2022
edmooring
edmooring approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@arnopo arnopo merged commit 3a9119d into OpenAMP:main Nov 14, 2022
@arnopo
Copy link
Collaborator

arnopo commented Nov 14, 2022

I also updated the v2022.10 branch, we will create a 2022.10.1 tag with a version 1.3.1 at the end of the month to fix the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmooring edmooring edmooring approved these changes

@arnopo arnopo arnopo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release V2022.10
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiang781216 @arnopo @edmooring