Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadow warnings in application code and renforce CI build #440

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

arnopo
Copy link
Collaborator

@arnopo arnopo commented Nov 7, 2022

Based on #439

  • Fix shadows warning in applications.
  • Add new build flags to highlight warnings and treat warnings as an errors

@arnopo arnopo requested a review from edmooring November 7, 2022 17:14
@arnopo arnopo added this to the Release V2023.04 milestone Nov 7, 2022
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

fix warnings reported by gcc with compilation flag '-Wshadow'

Signed-off-by: Arnaud Pouliquen <[email protected]>
Add CMAKE_C_FLAGS warnings to highlight potential issue:
"-Wall -Wextra -Wshadow -Wunused-but-set-variable"
And force warning as error with "-Werror"

Signed-off-by: Arnaud Pouliquen <[email protected]>
@arnopo arnopo merged commit 081172c into OpenAMP:main Nov 28, 2022
@arnopo arnopo deleted the shadow_warns branch October 16, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants