Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Python client tests fail (syntax errors) #5377

Open
4 of 6 tasks
ghost opened this issue Feb 19, 2020 · 1 comment
Open
4 of 6 tasks

[BUG] Python client tests fail (syntax errors) #5377

ghost opened this issue Feb 19, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 19, 2020

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • What's the version of OpenAPI Generator used?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Bounty to sponsor the fix (example)
Description

After generating a python client for peertube, the tests don't run due to syntax errors:

openapi-generator version

@openapitools/openapi-generator-cli^1.0.10-4.2.3

OpenAPI declaration file content or url

https://framagit.org/LoveIsGrief/PeerTube/blob/44d4ee4fcb7cf8beebac73f85693c09919b91e66/support/doc/api/openapi.yaml

Command line used for generation

It's run in a bash script by a CI that calls the npm package. bash script | npm package (@openapitools/openapi-generator-cli^1.0.10-4.2.3) (line in yarn.lock)

the resulting command should be

npx openapi-generator generate
-i support/doc/api/openapi.yaml
-c "support/openapi/python/def.yaml"
-t "support/openapi/python"
-g "python"
--git-host "framagit"
--git-user-id "peertube-test"
--git-repo-id "apis/python"
-o "dist/api/python"

Steps to reproduce
  1. Generate python client from peertube api spec
  2. install virtualenv in output directory
  3. install requirements.txt and test-requirements.txt
  4. pytest
Related issues/PRs

#1747 had similar issues but the output was ignored? I'm not entirely sure.

Suggest a fix

Update the template to use the correct fieldnames. They are correctly generated in the model, but not in the test file.

@ghost ghost added the Issue: Bug label Feb 19, 2020
@tomplus
Copy link
Member

tomplus commented Feb 26, 2020

I'm faced the same problem. It looks like generated tests don't use model's arguments name which my be different than defined in a spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant