Update OpenAPI generator and the client #1188

palnabarun · 2020-06-22T16:19:03Z

This PR also:

Remove tests since they are stubs
Updates the CHANGELOG with changes from 1.16.9 to 1.16.11
Updates the CHANGELOG with changes from python-base
Update the hotfix script

Follow ups:

Update the release documentation

palnabarun · 2020-06-22T16:22:33Z

/assign @roycaihw @yliaog

palnabarun · 2020-06-22T16:28:33Z

There is a test failure in the base submodule:

        self.assertEqual(expected_token,
>                        config.auth_settings()['BearerToken']['value'])
E       KeyError: 'BearerToken'

kubernetes/base/config/kube_config_test.py:1373: KeyError

roycaihw

The commits LGTM in general. Once we collect the API change caused by openapi-generator in CHANGELOG we will be good to go.

roycaihw · 2020-06-22T21:47:16Z

kubernetes/test/test_admissionregistration_api.py

@@ -1,39 +0,0 @@
-# coding: utf-8


Upstream issue: OpenAPITools/openapi-generator#5377

roycaihw · 2020-06-22T22:56:15Z

There is a test failure in the base submodule

I checked python-base and found there was one pycodestyle failure merged accidentally. I sent a fix: kubernetes-client/python-base#200.

The error in #1188 (comment) looks different though. I created an experimental PR #1191 that only bumps python-base, to help us better identify if the bug is on our side or introduced by openapi-generator.

roycaihw · 2020-06-22T23:20:25Z

The tests passed in #1191. Looks like the KeyError is related to openapi-generator change.

roycaihw · 2020-07-16T07:13:14Z

The test failure

    def test_auth_settings_calls_get_api_key_with_prefix(self):
        expected_token = 'expected_token'
    
        def fake_get_api_key_with_prefix(identifier):
            self.assertEqual('authorization', identifier)
            return expected_token
        config = Configuration()
        config.get_api_key_with_prefix = fake_get_api_key_with_prefix
        self.assertEqual(expected_token,
>                        config.auth_settings()['BearerToken']['value'])
E       KeyError: 'BearerToken'

is related to the upstream change OpenAPITools/openapi-generator#4988. In the test we faked a Configuration with a customized get_api_key_with_prefix, but we didn't set the api_key thus the returned attribute was empty. We should append authorization to api_key of the fake Configuration in the test.

palnabarun · 2020-07-16T08:08:58Z

/reopen

(the bot mistakenly closed this due to kubernetes-client/python-base#202 merging)

k8s-ci-robot · 2020-07-16T08:09:00Z

@palnabarun: Reopened this PR.

In response to this:

/reopen

(the bot mistakenly closed this due to kubernetes-client/python-base#202 merging)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Nabarun Pal <[email protected]>

Reference: OpenAPITools/openapi-generator#5377 Signed-off-by: Nabarun Pal <[email protected]>

The upstream 1.16 API moved ahead due to [patch releases](https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md). The logs are gathered from the upstream [CHANGELOG](https://raw.githubusercontent.com/kubernetes/kubernetes/master/CHANGELOG/CHANGELOG-1.16.md). Signed-off-by: Nabarun Pal <[email protected]>

Reference: - [kubernetes-client#866](kubernetes-client#866) - [kubernetes-client#959](kubernetes-client#959) Signed-off-by: Nabarun Pal <[email protected]>

Reference: kubernetes-client#974 Signed-off-by: Nabarun Pal <[email protected]>

The implementation and tests were already picked up by the upstream OpenAPI generator [here](OpenAPITools/openapi-generator#5094). Patching in the tests here for correctness and clarity. Reference: kubernetes-client#1073 Signed-off-by: Nabarun Pal <[email protected]>

Signed-off-by: Nabarun Pal <[email protected]>

palnabarun · 2020-07-16T08:23:34Z

The build is again failing due to a regression caused in kubernetes-client/python-base#133.

Ref: https://travis-ci.org/github/kubernetes-client/python-base/builds/708448505

palnabarun · 2020-07-16T08:40:44Z

kubernetes-client/python-base#204 will fix the test failure.

Update from 49ec060 to fb86b8a Signed-off-by: Nabarun Pal <[email protected]>

palnabarun · 2020-07-18T15:29:29Z

After kubernetes-client/python-base#204 got merged, the tests are passing.

yliaog · 2020-07-18T21:58:18Z

CHANGELOG.md

 - Allow incluster to accept pass-in config [kubernetes-client/python-base#193](https://github.com/kubernetes-client/python-base/pull/193)
 - Set expiration on token of incluster config and reload the token if it expires [kubernetes-client/python-base#191](https://github.com/kubernetes-client/python-base/pull/191)

+**Bug Fix:**
+
+- Fixes a bug in loading kubeconfig when there are no users in ttthe config [kubernetes-client/python-base#198](https://github.com/kubernetes-client/python-base/pull/198)


Thanks for the catch. 👍 It is resolved now.

Signed-off-by: Nabarun Pal <[email protected]>

The changes have been listed in the CHANGELOG and linked to the respective milestone pull requests. Signed-off-by: Nabarun Pal <[email protected]>

roycaihw · 2020-07-20T16:04:36Z

/lgtm
/approve

k8s-ci-robot · 2020-07-20T16:04:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2020

k8s-ci-robot requested review from roycaihw and yliaog June 22, 2020 16:19

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 22, 2020

k8s-ci-robot assigned roycaihw and yliaog Jun 22, 2020

palnabarun force-pushed the update-openapi-generator branch from 6e0c532 to 5240b76 Compare June 22, 2020 16:24

roycaihw reviewed Jun 22, 2020

View reviewed changes

roycaihw mentioned this pull request Jun 22, 2020

[DO NOT MERGE] test: update python-base #1191

Closed

ACXLM mentioned this pull request Jun 26, 2020

update python base #1194

Merged

roycaihw mentioned this pull request Jul 16, 2020

Add old api_key to set auth attributes kubernetes-client/python-base#202

Merged

palnabarun mentioned this pull request Jul 16, 2020

Fix a test to new OpenAPI client configuration kubernetes-client/python-base#203

Closed

k8s-ci-robot closed this in kubernetes-client/python-base#202 Jul 16, 2020

k8s-ci-robot reopened this Jul 16, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020

palnabarun added 8 commits July 16, 2020 13:42

Update client with OpenAPI generator v4.3.0

b4d11b0

Signed-off-by: Nabarun Pal <[email protected]>

Remove tests since they have syntactical issues and are noop

ec9c944

Reference: OpenAPITools/openapi-generator#5377 Signed-off-by: Nabarun Pal <[email protected]>

Fix custom objects API to preserve backward compatibility

b78f5cf

Reference: - [kubernetes-client#866](kubernetes-client#866) - [kubernetes-client#959](kubernetes-client#959) Signed-off-by: Nabarun Pal <[email protected]>

Add kubernetes.client.apis as an alias to kubernetes.client.api

1461192

Reference: kubernetes-client#974 Signed-off-by: Nabarun Pal <[email protected]>

Update CHANGELOG with changes from python-base submodule

da2579a

Signed-off-by: Nabarun Pal <[email protected]>

Update the hotfix script

47768af

Signed-off-by: Nabarun Pal <[email protected]>

palnabarun force-pushed the update-openapi-generator branch from fc74c0a to 259e640 Compare July 16, 2020 08:12

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020

Updates python-base submodule

9a20c56

Update from 49ec060 to fb86b8a Signed-off-by: Nabarun Pal <[email protected]>

palnabarun force-pushed the update-openapi-generator branch from 259e640 to 9a20c56 Compare July 16, 2020 22:36

yliaog reviewed Jul 18, 2020

View reviewed changes

palnabarun added 2 commits July 19, 2020 12:33

Update CHANGELOG with latest changes from python-base

2a66466

Signed-off-by: Nabarun Pal <[email protected]>

Collate OpenAPI generator changes by version

08ed6c2

The changes have been listed in the CHANGELOG and linked to the respective milestone pull requests. Signed-off-by: Nabarun Pal <[email protected]>

palnabarun force-pushed the update-openapi-generator branch from 616e40d to 08ed6c2 Compare July 19, 2020 07:03

torgeirl mentioned this pull request Jul 19, 2020

Cut version 12.0.0 alpha for client #1052

Closed

3 tasks

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020

k8s-ci-robot merged commit bc79976 into kubernetes-client:master Jul 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update OpenAPI generator and the client #1188

Update OpenAPI generator and the client #1188

palnabarun commented Jun 22, 2020 •

edited

Loading

palnabarun commented Jun 22, 2020

palnabarun commented Jun 22, 2020

roycaihw left a comment

roycaihw Jun 22, 2020

roycaihw commented Jun 22, 2020

roycaihw commented Jun 22, 2020

roycaihw commented Jul 16, 2020

palnabarun commented Jul 16, 2020

k8s-ci-robot commented Jul 16, 2020

palnabarun commented Jul 16, 2020

palnabarun commented Jul 16, 2020

palnabarun commented Jul 18, 2020

yliaog Jul 18, 2020

palnabarun Jul 19, 2020

roycaihw commented Jul 20, 2020

k8s-ci-robot commented Jul 20, 2020

Update OpenAPI generator and the client #1188

Update OpenAPI generator and the client #1188

Conversation

palnabarun commented Jun 22, 2020 • edited Loading

palnabarun commented Jun 22, 2020

palnabarun commented Jun 22, 2020

roycaihw left a comment

Choose a reason for hiding this comment

roycaihw Jun 22, 2020

Choose a reason for hiding this comment

roycaihw commented Jun 22, 2020

roycaihw commented Jun 22, 2020

roycaihw commented Jul 16, 2020

palnabarun commented Jul 16, 2020

k8s-ci-robot commented Jul 16, 2020

palnabarun commented Jul 16, 2020

palnabarun commented Jul 16, 2020

palnabarun commented Jul 18, 2020

yliaog Jul 18, 2020

Choose a reason for hiding this comment

palnabarun Jul 19, 2020

Choose a reason for hiding this comment

roycaihw commented Jul 20, 2020

k8s-ci-robot commented Jul 20, 2020

palnabarun commented Jun 22, 2020 •

edited

Loading