Migrate Sinexcel implementation to Battery-Inverter #1389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luding force charge/discharge mode fix checkstyle violations move CellCharacteristic interface to battery api update docs folder
# Conflicts: # io.openems.edge.battery.api/src/io/openems/edge/battery/api/Battery.java # io.openems.edge.battery.api/src/io/openems/edge/battery/api/SetAllowedCurrents.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/SetAllowedCurrents.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/Util.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionb/ClusterVersionB.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionb/SingleRack.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionc/ClusterVersionCImpl.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versiona/SingleRack.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionb/Config.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionb/SingleRackVersionBImpl.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionc/Config.java # io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionc/SingleRackVersionCImpl.java # io.openems.edge.battery.soltaro/test/io/openems/edge/battery/soltaro/UtilTest.java
- Migrate code to actual `BatteryProtection` class with handlers for ChargeMax and DischargeMax Current - Migrate one integration test Minor: - Update DummyBattery to accept additionalChannelIds - Update PolyLine for type safe and fluent calls - Add custom Callbacks to ComponentTest-Framework - Add TypeUtils to convert safely from Integer/Float to Double - TypeUtils.assertNull() throws an IllegalArgumentException; adapt OperatingSystemDebianSystemd-Service accordingly
If for the given 'cellVoltage' value 'voltageToPercent' defines a limitation (i.e. the given percentage is less than 100 %), that limitation stays active until a future 'cellVoltage' results in no limitation (i.e. percentage == 100 %). This is implemented to reduce fluctuations due to physical effects in the battery.
plus - improve null-handling in OpenemsComponent
- Remove ForceChargeActive and ForceDischargeActive channels on battery. They are replaced with more detailed BatteryProtection-ChannelIds. - Add BatteryProtection-ChannelIds - holds the input channels for original charge/discharge current by BMS - Replace Soltaro.Single.B SystemMaxChargeCurrent and DischargeCurrent with new Channels
…otection # Conflicts: # io.openems.edge.ess.generic/src/io/openems/edge/ess/generic/symmetric/ChannelManager.java
|
@huseyinsaht @pooran-c FYI. This is based on #1376. Still needs to be tested, but could serve as a basis for off-grid implementation |
|
Superseded by #1637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-Request migrates the existing Sinexcel implementation from ESS to BatteryInverter, for being compatible with the Generic-ESS setup.