Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Sinexcel implementation to Battery-Inverter #1389

Closed
wants to merge 42 commits into from
Closed

Migrate Sinexcel implementation to Battery-Inverter #1389

wants to merge 42 commits into from

Commits on Jan 19, 2021

  1. replaces dummy characteristic

    @wgerbl
    wgerbl committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    b36f120 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. implements allowed charge/discharge logic for all soltaro systems inc… 

    …luding force charge/discharge mode

fix checkstyle violations
move CellCharacteristic interface to battery api
update docs folder
    @wgerbl
    wgerbl committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    55a8b55 View commit details
    Browse the repository at this point in the history

  2. add constant

    @wgerbl
    wgerbl committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    d6d98d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Add new features to PolyLine

    @sfeilmeier
    sfeilmeier committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    d5b6824 View commit details
    Browse the repository at this point in the history

  2. Add TypeUtils min and multiply for type Double

    @sfeilmeier
    sfeilmeier committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    5732585 View commit details
    Browse the repository at this point in the history

  3. Software architecture draft for battery-protection using polylines

    @sfeilmeier
    sfeilmeier committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    a2c34ca View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feature/battery-protection 

    # Conflicts:
#	io.openems.edge.battery.api/src/io/openems/edge/battery/api/Battery.java
#	io.openems.edge.battery.api/src/io/openems/edge/battery/api/SetAllowedCurrents.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/SetAllowedCurrents.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/Util.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionb/ClusterVersionB.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionb/SingleRack.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/cluster/versionc/ClusterVersionCImpl.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versiona/SingleRack.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionb/Config.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionb/SingleRackVersionBImpl.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionc/Config.java
#	io.openems.edge.battery.soltaro/src/io/openems/edge/battery/soltaro/single/versionc/SingleRackVersionCImpl.java
#	io.openems.edge.battery.soltaro/test/io/openems/edge/battery/soltaro/UtilTest.java
    @sfeilmeier
    sfeilmeier committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    673f3fc View commit details
    Browse the repository at this point in the history

  5. Reset files to develop

    @sfeilmeier
    sfeilmeier committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    0783b03 View commit details
    Browse the repository at this point in the history

  6. Add Force-Discharge mode

    @sfeilmeier
    sfeilmeier committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    9b13c0a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2021

  1. Merge remote-tracking branch 'origin/develop' into feature/battery-pr… 

    …otection
    @sfeilmeier
    sfeilmeier committed Jan 30, 2021
    Configuration menu
    Copy the full SHA
    414373e View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Continued work... 

    - Migrate code to actual `BatteryProtection` class with handlers for ChargeMax and DischargeMax Current
- Migrate one integration test

Minor:
- Update DummyBattery to accept additionalChannelIds
- Update PolyLine for type safe and fluent calls
- Add custom Callbacks to ComponentTest-Framework
- Add TypeUtils to convert safely from Integer/Float to Double
- TypeUtils.assertNull() throws an IllegalArgumentException; adapt OperatingSystemDebianSystemd-Service accordingly
    @sfeilmeier
    sfeilmeier committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    30f9e88 View commit details
    Browse the repository at this point in the history

  2. Cleanup and apply autoformat

    @sfeilmeier
    sfeilmeier committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    d73e712 View commit details
    Browse the repository at this point in the history

  3. Add JUnit tests and alternative configuration with BatteryProtectionD… 

    …efinition file
    @sfeilmeier
    sfeilmeier committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    8bb1cb3 View commit details
    Browse the repository at this point in the history

  4. Avoid NullPointerExceptions

    @sfeilmeier
    sfeilmeier committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    4253bc3 View commit details
    Browse the repository at this point in the history

  5. Avoid NullPointerExceptions

    @sfeilmeier
    sfeilmeier committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    0705ab1 View commit details
    Browse the repository at this point in the history

  6. Apply BatteryProtection to Soltaro Single B

    @sfeilmeier
    sfeilmeier committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    358c810 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Add enhanced calculation of Voltage-to-Percent limits 

    If for the given 'cellVoltage' value 'voltageToPercent' defines a limitation (i.e. the given percentage is less than 100 %), that limitation stays active until a future 'cellVoltage' results in no limitation (i.e. percentage == 100 %). This is implemented to reduce fluctuations due to physical effects in the battery.
    @sfeilmeier
    sfeilmeier committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    8eaa6ee View commit details
    Browse the repository at this point in the history

  2. Add discharge voltage-to-percent ramp for soltaro batteries

    @sfeilmeier
    sfeilmeier committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    4a35464 View commit details
    Browse the repository at this point in the history

  3. Avoid rounding issues on 1 % per Cycle ramp for AllowedCharge/Dischar… 

    …gePower
    @sfeilmeier
    sfeilmeier committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    ce77ac5 View commit details
    Browse the repository at this point in the history

  4. Fine tuning of Soltaro Battery Protection

    @sfeilmeier
    sfeilmeier committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    3a0a5e3 View commit details
    Browse the repository at this point in the history

  5. Fine tuning of Soltaro Battery Protection

    @sfeilmeier
    sfeilmeier committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    45e44b4 View commit details
    Browse the repository at this point in the history

  6. Fine tuning of Soltaro Battery Protection

    @sfeilmeier
    sfeilmeier committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    8b4af9e View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Fine tuning of Soltaro Battery Protection

    @sfeilmeier
    sfeilmeier committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    9517987 View commit details
    Browse the repository at this point in the history

  2. Extend definition of BatteryProtectionDefinition

    @sfeilmeier
    sfeilmeier committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    d26abe6 View commit details
    Browse the repository at this point in the history

  3. Fine tuning of Soltaro Battery Protection: temperature limits

    @sfeilmeier
    sfeilmeier committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    43321ed View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Force Charge/Discharge: wait 60 seconds + implement state-machine 

    plus
- improve null-handling in OpenemsComponent
    @sfeilmeier
    sfeilmeier committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    71e50bd View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Soltaro: adjust max charge temperature according to datasheet

    @sfeilmeier
    sfeilmeier committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    31a1a96 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Updates 

    - Remove ForceChargeActive and ForceDischargeActive channels on battery. They are replaced with more detailed BatteryProtection-ChannelIds.
- Add BatteryProtection-ChannelIds
  - holds the input channels for original charge/discharge current by BMS
- Replace Soltaro.Single.B SystemMaxChargeCurrent and DischargeCurrent with new Channels
    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    6f31e15 View commit details
    Browse the repository at this point in the history

  2. Recover old Battery-Protection

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    1906515 View commit details
    Browse the repository at this point in the history

  3. Add Channels for debugging via Grafana Dashboard

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    af3ad85 View commit details
    Browse the repository at this point in the history

  4. Add readme

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b973784 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/develop' into feature/battery-pr… 

    …otection

# Conflicts:
#	io.openems.edge.ess.generic/src/io/openems/edge/ess/generic/symmetric/ChannelManager.java
    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e148bb2 View commit details
    Browse the repository at this point in the history

  6. Apply Checkstyle, update JavaDocs and JUnit test framework

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    62d2bb1 View commit details
    Browse the repository at this point in the history

  7. Apply Checkstyle

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    06a2c93 View commit details
    Browse the repository at this point in the history

  8. Fix ForceCharge

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a199c14 View commit details
    Browse the repository at this point in the history

  9. Improve State-Machine logging

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    9017411 View commit details
    Browse the repository at this point in the history

  10. Fix ForceCharge

    @sfeilmeier
    sfeilmeier committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    9358e3b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. Fix Force-Charge Channel in DischargeCurrentHandler

    @sfeilmeier
    sfeilmeier committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    07c25c1 View commit details
    Browse the repository at this point in the history

  2. Extract calculation of AllowedCharge/DischargePower + add JUnit tests

    @sfeilmeier
    sfeilmeier committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8d8944b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into feature/battery-pr… 

    …otection
    @sfeilmeier
    sfeilmeier committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    20d296e View commit details
    Browse the repository at this point in the history

  4. Sinexcel: ignore active power < 100 W

    @sfeilmeier
    sfeilmeier committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    be38a0b View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Start migration of Sinexcel ESS to BatteryInverter

    @sfeilmeier
    sfeilmeier committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    209380c View commit details
    Browse the repository at this point in the history