add eslint:recommended and plugin:@typescript-eslint/recommended #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miettal
force-pushed
the
feature/add-new-eslint-rules-based-on-best-practice
branch
from
2c8f10b
to
abcce42
Compare
|
|
lukasrgr
approved these changes
Mar 18, 2024
ui/src/app/edge/live/Controller/Io/ChannelSingleThreshold/modal/modal.component.ts
Show resolved
Hide resolved
ui/src/app/edge/live/Multiple/Evcs_Api_Cluster/modal/evcs-chart/evcs.chart.ts
Show resolved
Hide resolved
|
Thank you @miettal. The PR is ready to get merged after Lukas' review. Unfortunately it has conflicts with develop and I don't have write permissions on the branch. Could you please either merge from develop or give me write access to fix it myself? Thanks! |
|
OK. I understood the situation. I will rebase this PR. |
miettal
force-pushed
the
feature/add-new-eslint-rules-based-on-best-practice
branch
from
abcce42
to
9788e6f
Compare
|
|
done |
Sn0w3y
added a commit
to Sn0w3y/openems
that referenced
this pull request
Apr 8, 2024
* UI: fix & update translations (OpenEMS#2595) * Fix Emergency-Slider Translation * Fix EMERGENCY_RESERVE Case Match * Gitpod: add names+descriptions to ports (OpenEMS#2600) * UI: add eslint:recommended and plugin:@typescript-eslint/recommended (OpenEMS#2577) * add "eslint:recommended", "plugin:@typescript-eslint/recommended" to eslintrc * `eslint --fix src/` * Push version to 2024.4.0 * Start development of version 2024.5.0-SNAPSHOT * MQTT API Controller: add optional config parameter to specify a topic prefix (OpenEMS#2553) Co-authored-by: Stefan Feilmeier <[email protected]> * Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf (OpenEMS#2606) * Bump com.squareup.retrofit2:converter-gson from 2.10.0 to 2.11.0 in /cnf Bumps [com.squareup.retrofit2:converter-gson](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:converter-gson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump com.squareup.retrofit2:adapter-rxjava3 in /cnf Bumps [com.squareup.retrofit2:adapter-rxjava3](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:adapter-rxjava3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump com.squareup.retrofit2:converter-scalars in /cnf Bumps [com.squareup.retrofit2:converter-scalars](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:converter-scalars dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf Bumps [com.squareup.retrofit2:retrofit](https://github.com/square/retrofit) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/square/retrofit/releases) - [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md) - [Commits](square/retrofit@2.10.0...2.11.0) --- updated-dependencies: - dependency-name: com.squareup.retrofit2:retrofit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update bnd --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefan Feilmeier <[email protected]> * UI: Fix CSS in footer (OpenEMS#2594) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Stefan Feilmeier <[email protected]> Co-authored-by: Hiromasa Ihara <[email protected]> Co-authored-by: samuelBloch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fanass-dev
pushed a commit
to fanass-dev/openems
that referenced
this pull request
May 6, 2024
…penEMS#2577) * add "eslint:recommended", "plugin:@typescript-eslint/recommended" to eslintrc * `eslint --fix src/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint:recommended and plugin:@typescript-eslint/recommended commonly used in eslint extends in typescript application development.
This changes add these extends to openems-ui project.
// Some rules was disabled because there are many errors, but in future resolving is better.