Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center Text in Footer #2594

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Center Text in Footer #2594

merged 3 commits into from
Apr 4, 2024

Conversation

Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Mar 29, 2024

No description provided.

Copy link

Code Coverage

@sfeilmeier
Copy link
Contributor

@lukasrgr: please check. Maybe I did a mistake while backporting?

Copy link

github-actions bot commented Apr 2, 2024

Code Coverage

@lukasrgr
Copy link
Contributor

lukasrgr commented Apr 3, 2024

@Sn0w3y what was your issue?

@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Apr 3, 2024

@lukasrgr, no problem at all, just a minor change but, in my opinion, a more elegant way to display the values in the footer.

@lukasrgr lukasrgr self-requested a review April 3, 2024 13:13
@lukasrgr
Copy link
Contributor

lukasrgr commented Apr 3, 2024

@Sn0w3y i had to deny my approval, i realized our internal version and openEMS are drifting apart at one point

@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Apr 3, 2024

@Sn0w3y i had to deny my approval, i realized our internal version and openEMS are drifting apart at one point

Actually i do not understand :o Means no centered Footer Data ?
Or could you then fix it by applying the same style than the internal Version ?

They are indeed drifting apart - also on the size of the Text in the Footer aswell

Greetings !

@lukasrgr
Copy link
Contributor

lukasrgr commented Apr 4, 2024

@Sn0w3y found it, apparently the new esLint configuration overwrote style applied in ts,

Apparently ng lint --fix is not always the best solution

Could you be so kind and fix the syntax in the applied style?

The Footer will be centered and also little bit smaller in height

@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Apr 4, 2024

@lukasrgr shoul be applied now ?

Greetings !

image

Copy link

github-actions bot commented Apr 4, 2024

Code Coverage

@Sn0w3y
Copy link
Contributor Author

Sn0w3y commented Apr 4, 2024

@lukasrgr should we exclude this from nglint possibly ?

This fixes also:

#2598

@sfeilmeier sfeilmeier merged commit 60b473f into OpenEMS:develop Apr 4, 2024
2 checks passed
@sfeilmeier sfeilmeier removed the request for review from venu-sagar April 4, 2024 17:07
@Sn0w3y Sn0w3y deleted the patch-6 branch April 4, 2024 17:11
Sn0w3y added a commit to Sn0w3y/openems that referenced this pull request Apr 8, 2024
* UI: fix & update translations (OpenEMS#2595)

* Fix Emergency-Slider Translation
* Fix EMERGENCY_RESERVE Case Match

* Gitpod: add names+descriptions to ports (OpenEMS#2600)

* UI: add eslint:recommended and plugin:@typescript-eslint/recommended (OpenEMS#2577)

* add "eslint:recommended", "plugin:@typescript-eslint/recommended" to eslintrc
* `eslint --fix src/`

* Push version to 2024.4.0

* Start development of version 2024.5.0-SNAPSHOT

* MQTT API Controller: add optional config parameter to specify a topic prefix (OpenEMS#2553)

Co-authored-by: Stefan Feilmeier <[email protected]>

* Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf (OpenEMS#2606)

* Bump com.squareup.retrofit2:converter-gson from 2.10.0 to 2.11.0 in /cnf

Bumps [com.squareup.retrofit2:converter-gson](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:converter-gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump com.squareup.retrofit2:adapter-rxjava3 in /cnf

Bumps [com.squareup.retrofit2:adapter-rxjava3](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:adapter-rxjava3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump com.squareup.retrofit2:converter-scalars in /cnf

Bumps [com.squareup.retrofit2:converter-scalars](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:converter-scalars
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump com.squareup.retrofit2:retrofit from 2.10.0 to 2.11.0 in /cnf

Bumps [com.squareup.retrofit2:retrofit](https://github.com/square/retrofit) from 2.10.0 to 2.11.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/trunk/CHANGELOG.md)
- [Commits](square/retrofit@2.10.0...2.11.0)

---
updated-dependencies:
- dependency-name: com.squareup.retrofit2:retrofit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update bnd

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stefan Feilmeier <[email protected]>

* UI: Fix CSS in footer (OpenEMS#2594)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Hiromasa Ihara <[email protected]>
Co-authored-by: samuelBloch <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fanass-dev pushed a commit to fanass-dev/openems that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants