Optimize Footer Visibility in /history Routes

[Sn0w3y]

Summary

This PR addresses an issue with the footer overlaying content in the /history/*** tab, which detracts from the user experience by obscuring important information. To enhance usability and content visibility, we've implemented conditional logic to hide the footer on specific /history/*** routes that present detailed content.

Changes Made

The main change involves modifying the FooterComponent to dynamically adjust its visibility based on the current route. Here's an overview of the code adjustments:

import { Router, NavigationEnd } from '@angular/router';
// Additional imports remain unchanged

@Component({
  selector: 'oe-footer',
  // Styles and template remain unchanged
})
export class FooterComponent implements OnInit {
  showFooter: boolean = true; // Flag to control footer visibility

  constructor(
    // Constructor dependencies remain unchanged
    private router: Router, // Injected Router for route tracking
  ) {}

  ngOnInit() 
this.router.events.pipe(filter(event => event instanceof NavigationEnd)).subscribe(() => {
          this.showFooter = !this.router.url.includes('/history');
        });

    // The rest of the ngOnInit logic remains unchanged
  }
}

Justification:

Given the /history tab's purpose to display detailed historical data and analyses, ensuring that this content is fully visible and unobstructed is crucial for user engagement and effectiveness of data presentation. This change directly contributes to improving the overall user experience by making adjustments based on the application's context and user needs.

[github-actions]

[sfeilmeier]

@Sn0w3y: We do not intend to hide the Footer in History tab. If there are visualization problems (like overlapping content), they have to be fixed without removing the Footer.

@lukasrgr FYI

Maybe in future we should find a way to discuss these ideas before implementating them in a Pull-Request. Other open source projects require a Issue for every PR. Maybe we should require a post in a OpenEMS Community subforum before we accept PRs?

[Sn0w3y]

@Sn0w3y: We do not intend to hide the Footer in History tab. If there are visualization problems (like overlapping content), they have to be fixed without removing the Footer.

@lukasrgr FYI

Maybe in future we should find a way to discuss these ideas before implementating them in a Pull-Request. Other open source projects require a Issue for every PR. Maybe we should require a post in a OpenEMS Community subforum before we accept PRs?

Well Stefan i can understand but in the detailledHistoryChart it indeed overlaps:

[Sn0w3y]

fixed in #2594