Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some new /config flags & /status property #595

Closed
KipK opened this issue Apr 10, 2023 · 4 comments · Fixed by #618
Closed

Add some new /config flags & /status property #595

KipK opened this issue Apr 10, 2023 · 4 comments · Fixed by #618
Assignees

Comments

@KipK
Copy link
Collaborator

KipK commented Apr 10, 2023

/config:

  • wizard_passed
    feature: set default to 0, when wizard has been passed once, set the flag to 1.
    comment: find a way to not display the wizard for upgraded setup. ssid is not sufficient as it doesn't solve ethernet module. Can we detect the whole config file is still default ?

  • default_state: 0 | 1 ( active | disabled )
    feature: allows to choose default evse state (active or disabled) when no override/claim has been setup.
    comment: I think EVSE fw should also be set to disabled by default, not sure this is the case or if it has any collaterals.

  • divert_type: -1 | 0 | 1 ( unset | solar | grid i/e )
    feature: store divert type. Remove needs of mqtt topic ( needed for http push ) ( -1 needed to import previous fw behavior )

  • vehicle_data_src: -1 | 0 | 1 | 2 ( unset | tesla | mqtt | http)
    feature: store vehicle data source. remove needs on checking tesla credentials or mqtt feed.

/status:

- mode_auto: 0|1
feature: match the auto mode from UI, if there's no "state" property set in /override , then auto is 1
goal: remove some boilerplate code from UI side & simplify other integrations to match current UI2 use case.
comment: probably also need an endpoint on api to activate auto ( if called, it remove /override "state" property if there's other properties in the /override claim, or clear the override if there's only the "state" prop set. For now it's done on UI side. )

This was referenced Apr 28, 2023
@KipK
Copy link
Collaborator Author

KipK commented May 2, 2023

@jeremypoulter, for the default evse state, I can't find where is it hardcoded, can you point me to ?

@jeremypoulter
Copy link
Collaborator

https://github.com/OpenEVSE/ESP32_WiFi_V4.x/blob/master/src/evse_man.cpp#L169 I think

@KipK
Copy link
Collaborator Author

KipK commented May 2, 2023

I'm not sure about the mode_auto thing for now.
Current UX was made with the constrain of beeing compatible with old UI.
I'm removing it from this issue and postpone it after UI migration, there's probably things we can rethink a bit.

@KipK KipK self-assigned this May 2, 2023
@KipK
Copy link
Collaborator Author

KipK commented May 2, 2023

#618 achieve all those & seems to work well here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants