-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: BEMT was disabled for negative inflow #1037
Conversation
The check to turn off BEM for low TSRs should have been using `ABS(TSR)` instead of `TSR` so that BEM is not disabled for all negative TSR values. OpenFAST#940
Merge this around the same time we do PR #932 |
@bjonkman could you update the r-test commit here to |
Actually, it looks like you also updated the r-test commit previously. I've updated the AeroDyn cases that are currently failing in |
That "update" was just to get the submodule to point to the most recent dev commit, which it should have done when I merged the branch (on the next commit). I just did an extra commit because the submodule initialization was being a pain on my computer today. Anyway, it should be pointing to your updated r-test commit now. Thanks for updating it! |
Feature or improvement description
The check to turn off BEM for low TSRs should have been using
ABS(TSR)
instead ofTSR
so that BEM is not disabled for all negative TSR values.Related issue, if one exists
#940
Impacted areas of the software
AeroDyn
Additional supporting information
Test results, if applicable
Tests where TSR < -1.5 will have differences due to BEM now turning back on at that point.
AD Timeseries Shutdown case (AD driver):
AD BAR RNA motion case (AD driver):