Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: UA update states that were not updated #932

Merged
merged 9 commits into from
Jul 7, 2022

Conversation

ebranlard
Copy link
Contributor

Feature or improvement description
Apparent bug in UA where states are never updated.

Related issue, if one exists
#799

Impacted areas of the software
UA (AeroDyn)

Tests
Tests using AFAeroMod=2 and UAMod=2,3 are expected to fail:

  • ad_Kite_OLAF
  • OpenFAST r-tests.

@rafmudaf
Copy link
Collaborator

The difference in ad_Kite_OLAF is very small

Screen Shot 2022-04-20 at 6 16 26 PM

@ebranlard
Copy link
Contributor Author

Yes, I'd recommend updating the baselines as I do think this is a bug (having a small impact though).

@rafmudaf rafmudaf changed the title UA: some states were never updated BugFix: UA update states that were not updated Jun 2, 2022
@rafmudaf
Copy link
Collaborator

rafmudaf commented Jul 6, 2022

The following regression test cases fail:

 17 - 5MW_Land_DLL_WTurb (Failed)
 18 - 5MW_OC3Mnpl_DLL_WTurb_WavesIrr (Failed)
 19 - 5MW_OC3Trpd_DLL_WSt_WavesReg (Failed)
 20 - 5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth (Failed)
 22 - 5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti (Failed)
 23 - 5MW_OC3Spar_DLL_WTurb_WavesIrr (Failed)
 24 - 5MW_OC4Semi_WSt_WavesWN (Failed)
 25 - 5MW_Land_BD_DLL_WTurb (Failed)

Upon inspection of the difference plots, the results after this change are very similar to before this change. I've uploaded all the plots here except for the 5MW_Land_BD_DLL_WTurb case because the file size exceeds the 25MB limit.

5MW_TLP_DLL_WTurb_WavesIrr_WavesMulti.html.zip
5MW_OC3Trpd_DLL_WSt_WavesReg.html.zip
5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth.html.zip
5MW_OC4Semi_WSt_WavesWN.html.zip
5MW_Land_DLL_WTurb.html.zip
5MW_OC3Mnpl_DLL_WTurb_WavesIrr.html.zip
5MW_OC3Spar_DLL_WTurb_WavesIrr.html.zip

@rafmudaf rafmudaf merged commit f571e9d into OpenFAST:dev Jul 7, 2022
@rafmudaf rafmudaf mentioned this pull request Jul 8, 2022
10 tasks
@ebranlard ebranlard deleted the f/UA-states branch May 15, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants