Skip to content

Commit

Permalink
Removed Duplicate Expansion (#909)
Browse files Browse the repository at this point in the history
Fixes #904

Query Template expanded twice.  This is unnecessary and would have
caused a performance issue at scale.
  • Loading branch information
kdavisk6 authored Mar 8, 2019
1 parent 6b8ed38 commit ce66205
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/main/java/feign/RequestTemplate.java
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public RequestTemplate resolve(Map<String, ?> variables) {
QueryTemplate queryTemplate = queryTemplates.next();
String queryExpanded = queryTemplate.expand(variables);
if (Util.isNotBlank(queryExpanded)) {
query.append(queryTemplate.expand(variables));
query.append(queryExpanded);
if (queryTemplates.hasNext()) {
query.append("&");
}
Expand Down

0 comments on commit ce66205

Please sign in to comment.