Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Duplicate Expansion #909

Merged

Conversation

kdavisk6
Copy link
Member

Fixes #904

Query Template expanded twice. This is unnecessary and would have
caused a performance issue at scale.

Fixes OpenFeign#904

Query Template expanded twice.  This is unnecessary and would have
caused a performance issue at scale.
@kdavisk6 kdavisk6 added the bug Unexpected or incorrect behavior label Feb 18, 2019
@kdavisk6 kdavisk6 merged commit ce66205 into OpenFeign:master Mar 8, 2019
@kdavisk6 kdavisk6 added this to the 10.2.1 milestone Apr 28, 2019
@kdavisk6 kdavisk6 deleted the gh-904-duplicate-query-expansion branch May 9, 2019 13:51
velo pushed a commit that referenced this pull request Oct 7, 2024
Fixes #904

Query Template expanded twice.  This is unnecessary and would have
caused a performance issue at scale.
velo pushed a commit that referenced this pull request Oct 8, 2024
Fixes #904

Query Template expanded twice.  This is unnecessary and would have
caused a performance issue at scale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queryTemplate.expand(variables) execute twice here
1 participant