Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tlg0062 varia #2751

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gregorycrane
Copy link
Contributor

there are some changes to the Lucian files that should be saved before we move the files.

@lcerrato
Copy link
Collaborator

lcerrato commented Jul 21, 2023

@gregorycrane
Why is tlg0018 in this PR? I would recommend a separate PR for that work. (I thought there was one we already made these same comments on, @AlisonBabeu?)

</respStmt>
<respStmt>
<persName>Gregory Crane</persName>
<resp>In 2023, GRC broke the translations up into works, cleaned up tagging of notes, and used digital files from CCEL.org to follow the sections as the appear in the David Scholer edition of the Yonge translation. He corrected many errors in the text but many remain.</resp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect

<principal xml:id="GRC">Gregory Crane</principal>
<respStmt>
<persName xml:id="Jouve">Jouve</persName>
<resp>OCR-ed, did a first pass of correction on, and encoded the text</resp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-standard

</persName>
</editor>
<author>Philo Alexandrinus</author>
<title xml:lang="eng">On the Creation of the World</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect to have this info here I think @AlisonBabeu already commented on this previously?

<teiHeader xml:lang="eng">
<fileDesc>
<titleStmt>
<title xml:lang="eng">The Works of Philo Judaeus</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for language here

</respStmt>
<respStmt>
<persName>Greta Franzini</persName>
<resp>Project Manager (University of Leipzig)</resp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the org is separate from the <resp> tag

</persName>
</editor>
<author>Philo Alexandrinus</author>
<title xml:lang="eng">On the Creation of the World</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no lang attribute needed for title

</encodingDesc>
<profileDesc>
<langUsage>
<language ident="en">English</language>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect


<div type="textpart" subtype="section" n="25">
<p>this is the doctrine of Moses, not mine. Accordingly he, when recording the creation of man, in words which follow, asserts expressly, that he was made in the image of God—and if the image be a part of the image, then manifestly so is the entire form, namely, the whole of this world perceptible by the external senses, which is a greater imitation of the divine image than the human form is. It is manifest also, that the archetypal seal, which we call that world which is perceptible only to the intellect, must itself be the archetypal model, the idea of ideas, the Reason of God.
<milestone unit="chapter" n="7"/></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would bump any milestones at the end of a section to the start of the next section (strange placement that happens in conversion)--otherwise sort of useless here

</div>

<div type="textpart" subtype="section" n="27">
<p>But if the beginning spoken of by Moses is not to be looked upon as spoken of according to time, then it may be natural to suppose that it is the beginning according to number that is indicated; so that, "In the beginning he created," is equivalent <corr>to "first</corr> of all he created the heaven;" for it is natural in reality that that should have been the first object created, being both the best of all created things, and being also made of the purest substance, because it was destined to be the most holy abode of the visible Gods who are perceptible by the external senses;</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<q> instead of quotation marks, but if quotation marks preserved, should be curly quotes


<div type="textpart" subtype="section" n="37">
<p>Immediately afterwards he, with great propriety and entire correctness, called it the heaven, either because it was already the boundary <ref n="9.1"/> of everything, or because it was the first of all visible things which was created; and after its second rising he called the time day, referring the entire space and measure of a day to the heaven, on account of its dignity and honour among the things perceptible to the external senses.
<milestone unit="chapter" n="11"/></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @gregorycrane and @lcerrato so beyond there being so many files and some encoding issues, from looking at the results of this first pull request, it also looks like there are XML errors in 4 files:

  • tlg0062.tlg018.1st1K-grc1.xml fatal: The element type "div" must be terminated by the matching end-tag "". [In (L183 C9)
  • tlg0062.tlg022.1st1K-grc1.xml fatal: The element type "p" must be terminated by the matching end-tag "

    ". [In (L726 C4)]
  • tlg0062.tlg024.1st1K-grc1.xml fatal: The element type "p" must be terminated by the matching end-tag "

    ". [In (L108 C43)]
  • tlg0062.tlg047.1st1K-grc1.xml error: text not allowed here [In (L220 C1)]

I"m happy to try and fix these on this pull request but I'm still wondering, Greg, if you could ultimately close this one, and perhaps resubmit several pull requests, that are about 10 files at a time to make it easier to review changes. I'm also happy to clone your repository and do that as well from this branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that fixed three of the files, it also turns out that tlg0062.tlg018.1st1K-grc1.xml had duplicated nodes, it has two section 34s. So I'm going tofix that next and see if that at least makes all the files valid.

Deleted an extra </p> tag.
Added in a missing</p> tag
Deleted an extraneous character outside XML tags (also checked against text)
Moved  Greek text inside note where it belonged, also corrected a typo in the footnote.
Double checked against the text here: 
https://archive.org/details/lucianhar05luciuoft/page/334/mode/2up
Added in missing <p> tags.
Updated the section numbers so there were no duplicate nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants