Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpMetrics-1.0 to be compatible with the final MicroProfile Metrics 1.0 release. #10

Merged
merged 16 commits into from
Sep 19, 2017
Merged

Update mpMetrics-1.0 to be compatible with the final MicroProfile Metrics 1.0 release. #10

merged 16 commits into from
Sep 19, 2017

Conversation

raymondlam
Copy link
Contributor

Fixes #8

aarb1 and others added 15 commits September 18, 2017 17:00
@aarb1 @raymondlam
Fixed OpenLiberty#1002
bb30918
@aarb1 @raymondlam
Fixed potential bug related to OPTIONS request with both text/plain a…
95da15f 
…nd application/json in header
@aarb1 @raymondlam
Fixed OpenLiberty#7790
d5a0694
@aarb1 @raymondlam
Changed initial content type checker to contains from matches
ed4875b
@Channyboy @raymondlam
Sync up with NOTICE file from MicroProfile Metrics Spec Project
1c78fe0
@aarb1 @raymondlam
Fixed OpenLiberty#7705
a1ca804
@aarb1 @raymondlam
Removed error codes from description messages in nlsprops and updated…
983494b 
… basemetrics accordingly
@aarb1 @raymondlam
Updated error messages, removed runtime exceptions, removed unnecessa…
7550683 
…ry tc var from basemetrics class
@raymondlam
Updating Prometheus output to conform to spec
7f6938b
@aarb1 @raymondlam
Changes to log messages, got proper references to Tr working, made ch…
6248e9e 
…anges to log messages and added more detail to them
@aarb1 @raymondlam
updated copyright
4574c59
@raymondlam
Fixing Unit check with Gauges, fix @Gauge missing metadata
3ce2756
@raymondlam
Fixes forwarding gauge from continually failing when application is u…
15226bd 
…nloaded. Fixes OpenLiberty#8069.
@aarb1 @raymondlam
Made some fixes to nlsprops
2961f6a
@raymondlam
Fixing metadata not being picked up for @Metric and tags for annotations
af2720a
@LibbyBot
Copy link

LibbyBot commented Sep 18, 2017 •
edited
Loading

Please code review, @OpenLiberty/reviewer

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 23 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 2 messages files were changed and need an L2 review.

  • @OpenLiberty/l2 Please review.

  • dev/com.ibm.ws.microprofile.metrics/resources/com/ibm/ws/microprofile/metrics/resources/Metrics.nlsprops

  • dev/com.ibm.ws.microprofile.metrics.cdi/resources/com/ibm/ws/microprofile/metrics/cdi/resources/MetricsCDI.nlsprops

  • 2 NLS files were changed and need an ID review.

  • @OpenLiberty/id Please review.

  • dev/com.ibm.ws.microprofile.metrics/resources/com/ibm/ws/microprofile/metrics/resources/Metrics.nlsprops

  • dev/com.ibm.ws.microprofile.metrics.cdi/resources/com/ibm/ws/microprofile/metrics/cdi/resources/MetricsCDI.nlsprops

fmhwong
fmhwong reviewed Sep 18, 2017
View reviewed changes
Copy link
Member

@fmhwong fmhwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@raymondlam
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_TcPPsJztEeew8ISV5CV8GQ

You changed feature files so I requested a "Liberty IM Offering Build - EBC" build for you:
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Tj5W4JztEeew8ISV5CV8GQ

Target locations of links might be accessible only to IBM employees.

@raymondlam raymondlam self-assigned this Sep 19, 2017
@LibbyBot
Copy link

The build raymondlam-10-20170919-0454
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_TcPPsJztEeew8ISV5CV8GQ
completed and has errors or failures.

fmhwong
fmhwong reviewed Sep 19, 2017
View reviewed changes
Copy link
Member

@fmhwong fmhwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fmhwong
fmhwong approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@fmhwong fmhwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raymondlam raymondlam mentioned this pull request Sep 19, 2017
Merged
@raymondlam raymondlam merged commit 45f8b50 into OpenLiberty:integration Sep 19, 2017
AidanPolese pushed a commit to AidanPolese/open-liberty that referenced this pull request Sep 24, 2018
@gmarcy
Merge pull request OpenLiberty#10 from gmarcy/sync-changes-between-repos
c78e5ee 
synchronize open-liberty and WS-CD-Open
herman-kailey added a commit to herman-kailey/open-liberty that referenced this pull request Oct 9, 2019
@herman-kailey
Merge pull request OpenLiberty#10 from herman-kailey/mavenRepo
e5995b8 
adding environment variable override for maven repository location
brenthdaniel added a commit to brenthdaniel/open-liberty that referenced this pull request Jul 11, 2022
@brenthdaniel
Merge pull request OpenLiberty#10 from ghost/patch-1
338fc80 
Cache Maven JAR files
volosied added a commit to volosied/open-liberty that referenced this pull request Aug 16, 2022
@volosied
# This is a combination of 14 commits.
f8aceeb 
# This is the 1st commit message:

drop 3.1 code

# This is the commit message OpenLiberty#2:

update jsp.3.1 to jakarta

# This is the commit message OpenLiberty#3:

enable failing el tests

# This is the commit message OpenLiberty#4:

Update spec level for 3.1 bundle

# This is the commit message OpenLiberty#5:

Fix transformations with new 3.1 bundle

# This is the commit message OpenLiberty#6:

Working pages 3.1 feature

# This is the commit message OpenLiberty#7:

groudwork for errorOnELNotFound

# This is the commit message OpenLiberty#8:

add .project

# This is the commit message OpenLiberty#9:

create page directive errorOnELNotFound

# This is the commit message OpenLiberty#10:

create page directive errorOnELNotFound - 23.1 bundle

# This is the commit message OpenLiberty#11:

WIP: jsp prop group for erroronelnotfound

# This is the commit message OpenLiberty#12:

Fix jsp 3.1 bnd

# This is the commit message OpenLiberty#13:

Fix jsp prop group finally

# This is the commit message OpenLiberty#14:

Almost workking jsp.factories ( need to fix getErrorOnELNotFound ) in interface
@tbitonti tbitonti mentioned this pull request Nov 15, 2022
Closed
mshah0722 added a commit to utle/open-liberty that referenced this pull request Nov 4, 2024
@mshah0722
Merge pull request OpenLiberty#10 from utle/FIPSwork
28aacf9 
import the missing package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmhwong fmhwong fmhwong approved these changes

Assignees

@raymondlam raymondlam

Labels
CLA Not Needed in:MicroProfile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@raymondlam @LibbyBot @fmhwong @aarb1 @Channyboy