Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microprofile Fault Tolerance changes (integration branch) #11

Merged
merged 4 commits into from
Sep 19, 2017
Merged

Microprofile Fault Tolerance changes (integration branch) #11

merged 4 commits into from
Sep 19, 2017

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented Sep 18, 2017

  • Close all executors when the bean is destroyed
  • Make Async CircuitBreakers work
  • Ensure interrupted flag is is cleared after timeout

@Azquelt
Really close all the executors when the bean is destroyed - Issue Ope…
3366e78 
…nLiberty#1094

Previously we were doing this in a @PreDestroy method on the
interceptor. However, that method will only fire if the interceptor is
bound to a class. It won't fire if the interceptor is just bound to a
method.

Since we regularly bind the FT Interceptor to methods, that's not
acceptable. The new solution injects a dependent bean into the
interceptor and the cleanup is done in its PreDestroy method.
@Azquelt
Make Async CircuitBreakers work
0496de2 
Unwrap ExecutionException when thrown from Async methods

Don't apply circuit breaker on outer part of Async call

Manually check the circuit breaker before the outside of the async call
and report failures only if the inner part can't be scheduled (usually
due to bulkhead).

Remove Failsafe fallback from Async Outer Executor - needed because
we're manually reporting failures to the circuit breaker and want to do
so before calling the fallback method.

Add test for Async CircuitBreaker and Async CircuitBreaker with Fallback
@Azquelt
Add tolerance to asyncDisabled test
a136d9b
@Azquelt
Ensure interrupted flag is cleared after Timeout OpenLiberty#938
7a36ade
@LibbyBot
Copy link

LibbyBot commented Sep 18, 2017 •
edited
Loading

Please code review, @OpenLiberty/reviewer

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 9 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 8 FAT files were changed.

  • Check that the build did not break the affected FAT suite(s).

@Azquelt Azquelt changed the title Microprofile changes (integration branch) Microprofile Fault Tolerance changes (integration branch) Sep 18, 2017
@Azquelt
Copy link
Member Author

Azquelt commented Sep 18, 2017

#build

@LibbyBot
Copy link

I cannot process this build request due to one or both of the following:

  • The comment author is not a member of the organization.
  • The pull request creator did not send a signed CLA.

@Azquelt
Copy link
Member Author

Azquelt commented Sep 19, 2017

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_q_LyQJ0REeew8ISV5CV8GQ

Target locations of links might be accessible only to IBM employees.

tevans78
tevans78 approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@tevans78 tevans78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@LibbyBot
Copy link

The build Azquelt-11-20170919-0915
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_q_LyQJ0REeew8ISV5CV8GQ
completed successfully!

@Azquelt Azquelt merged commit 06f1160 into OpenLiberty:integration Sep 19, 2017
@Azquelt Azquelt deleted the microprofile-changes-integration branch September 26, 2017 13:26
navidsh pushed a commit to navidsh/open-liberty that referenced this pull request Feb 5, 2018
@a-saf
Merge pull request OpenLiberty#11 from a-saf/encodingAndHeader
94011c1 
For issue OpenLiberty#1660: Encoding and header validators and unit tests
AidanPolese pushed a commit to AidanPolese/open-liberty that referenced this pull request Sep 24, 2018
@cbridgha
Merge pull request OpenLiberty#11 from was-liberty/travisBuild
97d6669 
Update .travis.yml
herman-kailey added a commit to herman-kailey/open-liberty that referenced this pull request Oct 10, 2019
@herman-kailey
Merge pull request OpenLiberty#11 from herman-kailey/mavenRepo
305cc63 
Maven repo
@mchenggit mchenggit mentioned this pull request Nov 18, 2019
Closed
brenthdaniel added a commit to brenthdaniel/open-liberty that referenced this pull request Jul 11, 2022
@brenthdaniel
Merge pull request OpenLiberty#11 from ghost/patch-2
1dd420f 
Update assemble
volosied added a commit to volosied/open-liberty that referenced this pull request Aug 16, 2022
@volosied
# This is a combination of 14 commits.
f8aceeb 
# This is the 1st commit message:

drop 3.1 code

# This is the commit message OpenLiberty#2:

update jsp.3.1 to jakarta

# This is the commit message OpenLiberty#3:

enable failing el tests

# This is the commit message OpenLiberty#4:

Update spec level for 3.1 bundle

# This is the commit message OpenLiberty#5:

Fix transformations with new 3.1 bundle

# This is the commit message OpenLiberty#6:

Working pages 3.1 feature

# This is the commit message OpenLiberty#7:

groudwork for errorOnELNotFound

# This is the commit message OpenLiberty#8:

add .project

# This is the commit message OpenLiberty#9:

create page directive errorOnELNotFound

# This is the commit message OpenLiberty#10:

create page directive errorOnELNotFound - 23.1 bundle

# This is the commit message OpenLiberty#11:

WIP: jsp prop group for erroronelnotfound

# This is the commit message OpenLiberty#12:

Fix jsp 3.1 bnd

# This is the commit message OpenLiberty#13:

Fix jsp prop group finally

# This is the commit message OpenLiberty#14:

Almost workking jsp.factories ( need to fix getErrorOnELNotFound ) in interface
mshah0722 added a commit to utle/open-liberty that referenced this pull request Nov 14, 2024
@mshah0722
Merge pull request OpenLiberty#11 from utle/FIPSwork
d6c428f 
Removve com.ibm.ws.common.crypto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevans78 tevans78 tevans78 approved these changes

Assignees
No one assigned
Labels
CLA Not Needed release-17.0.0.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azquelt @LibbyBot @tevans78