Update References to Documentation/Magento Website - Issue #988 #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: AdminNotification
Sdfendor
previously approved these changes
May 5, 2022
colinmollenhour
previously approved these changes
May 5, 2022
kiatng
previously approved these changes
May 6, 2022
luigifab
suggested changes
May 6, 2022
fballiano
dismissed stale reviews from kiatng, colinmollenhour, and Sdfendor
via
2910f07
colinmollenhour
approved these changes
May 13, 2022
|
Referring to this post #988 (comment), is there a possibility that certain extensions that are still maintained by developers may have issues with Mage_Adminhtml_Block_Notification_Window removal? Is this class still used? |
|
@ADDISON74, yes there's the possibility, although it would be an extremely bothering thing if an extension open an overlay when you access the backend, also the majority of vendors don't even support M1 extensions anymore so you know... anyway I'd remove the object only in the v20 branch, seems fair this PR doesn't remove that class anyway |
kiatng
approved these changes
May 15, 2022
ADDISON74
approved these changes
May 15, 2022
elidrissidev
approved these changes
May 17, 2022
luigifab
reviewed
May 18, 2022
luigifab
approved these changes
May 24, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #988 with a few last small changes.
I've follow @colinmollenhour last comment #988 (comment) because it made a lot of sense.
Also, some deprecated and unused code was removed (I did it in this same PR because it is part of the same topic).