Add back notification popup severity icons URL #2633
Conversation
github-actions
bot
added
the
Component: AdminNotification
|
Is someone keeping track of Magento 1 usage? |
|
From time to time I check https://trends.builtwith.com/shop/OpenMage |
I don't understand what you mean? |
A typical server keeps an access log of its resources, in this case, some gif's. The log can be mined for all sorts of analytics, which can be used for business intelligence, to determine market size of new products, distribution, trends, etc., just like the link provided by @sreichel, can be sold. So, you may be right, someone may not be too happy if the links are removed. |
I get it now. I don't think Magento team still cares about M1's usage numbers, but since they chose to put those icons in a remote server, I'm not sure that we can just download them and store them locally just like that, and who knows maybe they'll take them down sometime. But anyways one link won't hurt. |
* Fixed "should return string but returns false" * Fixed "should return XYZ but returns false" * Fixed "should return array but returns null" * Fixed "should return string but returns null" * Fixed "should return int but returns null" * Fixed "should return bool but returns" * Fixed docs (see comments) * Fixed "should return array" * Update app/code/core/Mage/Adminhtml/Block/Widget/Grid/Massaction/Abstract.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Tag/Model/Resource/Tag.php Co-authored-by: Ng Kiat Siong <[email protected]> * Update app/code/core/Mage/Customer/Block/Form/Register.php Co-authored-by: Ng Kiat Siong <[email protected]> * Added module names to helper(#2617) * Get catalog search result collection from engine (#2634) * Add PHP dependencies security check workflow (#2639) * [security-workflow] Fixed cron syntax (#2640) * Added OpenMage Contributors Copyright (#2295) * Added ddev snippets to docs (#2575) * Improve dev/openmage/install.sh script for newer versions of Docker - no longer requires separate compose. * Only run workflows when relevant files change (#2641) * Add back notification popup severity icons URL (#2633) * Reduce reprocessed jpeg file size by defaulting quality to 85% (#2629) * Fixed issue #475. * Removed <frontend_type>text</frontend_type> as it is the default. * Fixed bug on users not able to modify image quality in backend if deprecated config exists. * Fixed bug on incorrect check if image quality was not set in backend. * Improved note in system.xml. * Prevented editing of a non-editable order (#2632) * Fix dev/openmage/install.sh script setting permissions on var directory. * Allowed automatic full invoice from API (#2393) * Add check if array key isset before using it (#2649) * Fixed phpstan-baseline.neon * Fixed phpstan-baseline.neon (updated dev tools) * Revert "Fixed phpstan-baseline.neon" This reverts commit 3c82e76. * Fixed getRegion() Co-authored-by: Ng Kiat Siong <[email protected]> Co-authored-by: Mohamed ELIDRISSI <[email protected]> Co-authored-by: Justin Beaty <[email protected]> Co-authored-by: Colin Mollenhour <[email protected]> Co-authored-by: luigifab <[email protected]> Co-authored-by: Przemysław Piotrowski <[email protected]>
Description (*)
This PR will add back a config that stored a URL used for notifications popup icons (weird I know!) that was removed in a previous cleanup PR. We could've copied and used them locally from
skin/, but I'm not sure if that's permissible since they exist in a remote server.Related Pull Requests
#2069
Manual testing scenarios (*)
Contribution checklist (*)