User-configurable cron expression for regular cache flushing #2086 #2087
Conversation
Revert default cron expression to original 30 2 * * *
| <show_in_default>1</show_in_default> | ||
| <show_in_website>0</show_in_website> | ||
| <show_in_store>0</show_in_store> | ||
| <comment>Use 0 0 30 2 0 to never run cron, the recommended setting is 30 3 * * 6</comment> |
There was a problem hiding this comment.
Just curious, why do you recommend to run weekly at 03:30 on Saturday instead of the current default of daily at 02:30?
Suggest to enclose the value with double quotes: "0 0 30 2 0", "30 3 * * 6".
| <comment>Use 0 0 30 2 0 to never run cron, the recommended setting is 30 3 * * 6</comment> | |
| <comment>Use "0 0 30 2 0" to never run cron, the recommended setting is "30 3 * * 6"</comment> |
There was a problem hiding this comment.
It's mentioned here: #2087 (comment)
|
For me is ok. Best option will be to merge this PR with original default value and create PR to 20.x for changed expression for weekly run. |
|
I analyzed OpenMage Backend and I found only one section where we can configure a cron job. Below is the implementation of the Magento team for Sitemap.
This PR can be modified to provide the same timing and we would keep a standard format of the change in Backend. I would choose two values: Start Time with 3 drop-downs (hour, minute, second) and Frequency which can be a drop-down with the same options like in the image (Always, Hourly, Daily, Weekly, Monthly, Yearly, Never). This is a more elegant and intuitive approach than filling in space delimited values in an input box with a help label bellow. In this way errors are avoided in entering wrong values that can affect the correct functionality. |
|
@addison74 it's used somewhere like here:
so to me it's really fine the way @LukasCesal built it :-) |
There was a problem hiding this comment.
A translate attribute is missing for cache tag: translate="label".
A translate attribute is missing for flush_cron_expr tag: translate="label comment".
Magento is now OpenMage, so instead of change that, I suggest to remove the word.
To never run cron, you just have to leave the field empty, right? I don't remember.
Sekiphp
deleted the
User-configurable-cron-expression-for-regular-cache-flushing-#2086
branch
Description (*)
(#2086)
Contribution checklist (*)