-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addendum to PR 2087 #2308
Addendum to PR 2087 #2308
Conversation
The default value used in OpenMage is "30 2 * * *" inherited from Magento. This value is displayed in the box but if the configuration is not saved it will not be recorded as a row in the core_config_data table. Once it's saved in the table the default value will no longer be used, but the established one. If the box is left empty the cron will not run. If the value in the table is deleted the default value will be used again. I made the necessary changes in the comment. I used the expression "no longer run" because until then the cron was running. The "never run" variant is not suitable because this cron can run in a certain situation. PS - I answered @luigifab's question addressed in the initial PR. As long as the cron does not run if the box is empty, it is no longer necessary to mention in the comment the running on February 30th. I updated the screenshot too. |
I would maybe suggest something like:
But I think this line has seen many suggested revisions, so it doesn't matter too much in the end. |
It should be fine now. |
Does translations still work with locale packs? (IMHO only output should be changed) |
* Update system.xml * Update Mage_Core.csv * Update Mage_Core.csv * Update system.xml * Update system.xml * Update Mage_Core.csv * Update system.xml * Update system.xml * Update Mage_Core.csv * Update system.xml * Update Mage_Core.csv
This PR adds the missing translation strings, removes word Magento, changes the label format with capitalize letters as it is throughout the Backend. It also adds a simple explicit comment.
This is how the Backend implementation looks like if this PR is merged: