Hotfix: broken workflow #2778
Merged
Hotfix: broken workflow #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
fballiano
reviewed
Dec 3, 2022
Comment on lines
+49
to
+51
| # if: | | ||
| # needs.check.outputs.composer > 0 || | ||
| # needs.check.outputs.workflow > 0 |
There was a problem hiding this comment.
could we remove these lines instead or we need them in the future?
There was a problem hiding this comment.
I'd like to keep them for now. I already have an idea to fix it, but i need some time for tests.
fballiano
approved these changes
Dec 3, 2022
addison74
approved these changes
Dec 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Sorry. last workflow update was not complete. Composer check was always true for my test ... composer "skipped" status is not detected, so all other checks are skipped now ... OpenMage/magento-lts#2773
Composer will be validated every time now.
Related Pull Requests
Contribution checklist (*)