Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: broken workflow #2778

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Hotfix: broken workflow #2778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/sonar.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ jobs:
env:
COMPOSER_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Validate composer
run: composer validate --strict

- name: Get composer cache directory
id: composer-cache
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,15 @@ jobs:
composer:
name: Composer
needs: [check]
if: |
needs.check.outputs.composer > 0 ||
needs.check.outputs.workflow > 0
# if: |
# needs.check.outputs.composer > 0 ||
# needs.check.outputs.workflow > 0
Comment on lines +49 to +51
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove these lines instead or we need them in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep them for now. I already have an idea to fix it, but i need some time for tests.

uses: ./.github/workflows/composer.yml

phpcs:
name: PHPCS
needs: [check, composer]
if: |
(needs.composer.result == 'success' || needs.composer.result == 'skipped') ||
needs.check.outputs.php > 0 ||
needs.check.outputs.phpcs > 0 ||
needs.check.outputs.composer > 0 ||
Expand All @@ -66,7 +65,6 @@ jobs:
name: PHP-CS-Fixer
needs: [check, composer]
if: |
(needs.composer.result == 'success' || needs.composer.result == 'skipped') ||
needs.check.outputs.php > 0 ||
needs.check.outputs.php-cs-fixer > 0 ||
needs.check.outputs.composer > 0 ||
Expand All @@ -77,7 +75,6 @@ jobs:
name: PHPStan
needs: [check, composer, phpcs, php-cs-fixer]
if: |
(needs.composer.result == 'success' || needs.composer.result == 'skipped') ||
needs.check.outputs.php > 0 ||
needs.check.outputs.phpstan > 0 ||
needs.check.outputs.composer > 0 ||
Expand Down