-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Google Analytics 4 Enhanced eCommerce #3198
Conversation
…, remove from cart, cart view, and begin_checkout.
Co-authored-by: Fabrizio Balliano <[email protected]>
I'd suggest to make the PR "editable by admins" ;-) |
Co-authored-by: Fabrizio Balliano <[email protected]>
try now - it was still a draft, maybe why you couldn't edit. |
mmm shouldn't be that, there's no "Add more commits by pushing to the..." message, it should be managed though something like this: https://github.blog/changelog/2023-02-10-see-when-a-pull-request-is-editable-by-maintainers/ |
thank you for this PR because it's a great feature to have!! |
That button doesn't exist for me... Maybe because it's not technically a user-owned fork (as it's owned by our company not my acct personally)? hmmmm |
@discountscott could be, it's not a problem at the moment anyway :-) |
Looks like that is the issue, GitHub support ticket response:
|
Hi @discountscott, do you think you'll be able to check the changes we discussed and the new suggestions? this PR is very interesting but if you wan't finish it I'd have to reopen it (as a new one) in order to be able to modify it. |
I apologize for the delay in these changes being implemented... I'll try and implement this week |
@fballiano Should be good to go now. No longer has the admin preference and it is integrated right into the standard GA4 implementation. |
Co-authored-by: Fabrizio Balliano <[email protected]>
Co-authored-by: Fabrizio Balliano <[email protected]>
It was good that we merged it. If changes or improvements are requested, we will know soon because the old code will no longer be functional. A good evaluation possibility to find out how many still use the Magento 1 platform too. |
I saw that two observers has been added with this PR. |
Description (*)
Adds support for enhanced eCommerce event data in GA4.
Creates events for product view, category view, add to cart, remove from cart, cart view, begin checkout. Purchase events are already being sent.
Details on implementation from Google can be found here: https://developers.google.com/analytics/devguides/collection/ga4/ecommerce?client_type=gtag
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Enable Enhanced eCommerce
toYES
view_item_list
Screenshots from Google Analytics Tag Debugging:
Questions or comments
Contribution checklist (*)